You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/04/21 19:58:39 UTC
Review Request 72408: Made the scheduler resources a top-level item
in the documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72408/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Benjamin Mahler, and Qian Zhang.
Repository: mesos
Description
-------
Made the scheduler resources a top-level item in the documentation.
Diffs
-----
docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
Diff: https://reviews.apache.org/r/72408/diff/1/
Testing
-------
Viewed using `site/mesos-website-dev.sh`
Thanks,
Greg Mann
Re: Review Request 72408: Made the scheduler resources a top-level
item in the documentation.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72408/#review220474
-----------------------------------------------------------
Ship it!
docs/home.md
Line 76 (original), 76 (patched)
<https://reviews.apache.org/r/72408/#comment308898>
If you want to avoid Framework another option is:
Scheduler and Executor Development
It seems like the scheduler and executor APIs should be in this section too. Maybe it's ok to have some duplication and have them both in this section and the APIs section?
- Benjamin Mahler
On April 21, 2020, 7:58 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72408/
> -----------------------------------------------------------
>
> (Updated April 21, 2020, 7:58 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the scheduler resources a top-level item in the documentation.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
>
>
> Diff: https://reviews.apache.org/r/72408/diff/1/
>
>
> Testing
> -------
>
> Viewed using `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72408: Made the scheduler resources a top-level
item in the documentation.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2020, 9:07 a.m., Qian Zhang wrote:
> > docs/home.md
> > Line 76 (original), 76 (patched)
> > <https://reviews.apache.org/r/72408/diff/1/?file=2224547#file2224547line76>
> >
> > Should we name it `Frameworks`?
I went with Ben's suggestion, let me know what you think!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72408/#review220415
-----------------------------------------------------------
On April 27, 2020, 11:55 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72408/
> -----------------------------------------------------------
>
> (Updated April 27, 2020, 11:55 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the scheduler resources a top-level item in the documentation.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
>
>
> Diff: https://reviews.apache.org/r/72408/diff/2/
>
>
> Testing
> -------
>
> Viewed using `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72408: Made the scheduler resources a top-level
item in the documentation.
Posted by Qian Zhang <zh...@gmail.com>.
> On April 22, 2020, 5:07 p.m., Qian Zhang wrote:
> > docs/home.md
> > Line 76 (original), 76 (patched)
> > <https://reviews.apache.org/r/72408/diff/1/?file=2224547#file2224547line76>
> >
> > Should we name it `Frameworks`?
>
> Greg Mann wrote:
> I went with Ben's suggestion, let me know what you think!
Yeah, I am OK with it.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72408/#review220415
-----------------------------------------------------------
On April 28, 2020, 7:55 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72408/
> -----------------------------------------------------------
>
> (Updated April 28, 2020, 7:55 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the scheduler resources a top-level item in the documentation.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
>
>
> Diff: https://reviews.apache.org/r/72408/diff/2/
>
>
> Testing
> -------
>
> Viewed using `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72408: Made the scheduler resources a top-level
item in the documentation.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72408/#review220415
-----------------------------------------------------------
Fix it, then Ship it!
docs/home.md
Line 76 (original), 76 (patched)
<https://reviews.apache.org/r/72408/#comment308802>
Should we name it `Frameworks`?
- Qian Zhang
On April 22, 2020, 3:58 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72408/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 3:58 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the scheduler resources a top-level item in the documentation.
>
>
> Diffs
> -----
>
> docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
>
>
> Diff: https://reviews.apache.org/r/72408/diff/1/
>
>
> Testing
> -------
>
> Viewed using `site/mesos-website-dev.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72408: Made the scheduler resources a top-level
item in the documentation.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72408/
-----------------------------------------------------------
(Updated April 27, 2020, 11:55 p.m.)
Review request for mesos, Andrei Budnik, Benjamin Mahler, and Qian Zhang.
Repository: mesos
Description
-------
Made the scheduler resources a top-level item in the documentation.
Diffs (updated)
-----
docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e
Diff: https://reviews.apache.org/r/72408/diff/2/
Changes: https://reviews.apache.org/r/72408/diff/1-2/
Testing
-------
Viewed using `site/mesos-website-dev.sh`
Thanks,
Greg Mann