[GitHub] [spark] ueshin commented on a change in pull request #32955: [SPARK-35344][PYTHON] Support creating a Column of numpy literals in pandas API on Spark

[GitBox <gi...@apache.org>]

ueshin commented on a change in pull request #32955:
URL: https://github.com/apache/spark/pull/32955#discussion_r660201798



##########
File path: python/pyspark/pandas/spark/functions.py
##########
@@ -32,6 +41,22 @@ def repeat(col: Column, n: Union[int, Column]) -> Column:
     return _call_udf(sc, "repeat", _to_java_column(col), n)
 
 
+def lit(literal: Any) -> Column:
+    """
+    Creates a Column of literal value.
+    """
+    if isinstance(literal, np.int64):

Review comment:
       I'm fine with the current implementation since sounds like the converter is difficult.
   I'd leave this to @HyukjinKwon.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org