You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/11/26 07:13:46 UTC
[GitHub] [incubator-echarts] pissang opened a new pull request #11713:
fix(bar): fix bar width calculation with barMaxWidth constraint and barGap
-100% #7356
pissang opened a new pull request #11713: fix(bar): fix bar width calculation with barMaxWidth constraint and barGap -100% #7356
URL: https://github.com/apache/incubator-echarts/pull/11713
The cause of this bug is in the line https://github.com/apache/incubator-echarts/blob/fix-bar-width-100/src/layout/barGrid.js#L292
The `width` will be constraint by the `remainedWidth`, which is the space can still be used for the remaining series. It is calcuated in https://github.com/apache/incubator-echarts/blob/fix-bar-width-100/src/layout/barGrid.js#L321 In the bug code, the barGap is not considered. So the calculated remaining width is much smaller than it should be when the barGap is set `-100%`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org