You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/05 05:42:21 UTC
[GitHub] [dolphinscheduler] Radeity opened a new issue, #12723: [Improvement][API] Check valid file parameter when defining process
Radeity opened a new issue, #12723:
URL: https://github.com/apache/dolphinscheduler/issues/12723
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When users want to transfer files between tasks and define `file` parameters(support in https://github.com/apache/dolphinscheduler/issues/12578), sometimes parameters are invalid for the sake of wrong file parameter name or even file parameter undefined. In current version, these errors can only be found during executing the process, thus, i think a check when defining process(before executing) is strongly needed.
I'll add function checkValidFileParams which will be called in the following methods in ProcessDefinitionServiceImpl:
```java
public Map<String, Object> createProcessDefinition(User loginUser, ...)
public Map<String, Object> updateProcessDefinition(User loginUser, ...)
```
********
More explanation, why only `file` parameter?
Because other types of parameters don't need explicit declaration, so that, finding which parameters is used in task have to parse task-related args and raw script. However, the action of process definition is actually unrelated to specific task type, it's improper to build task info and check here.
Rather, `file` parameters have explicit declaration and more reasonable to check here, in addition, intermediate files may be large, and once compute, we don't want re-compute it any more, which means less error is better.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12723: [Improvement][API] Check valid file parameter when defining process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12723:
URL: https://github.com/apache/dolphinscheduler/issues/12723#issuecomment-1304414430
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12723: [Improvement][dolphinscheduler-api] Check valid file parameter when defining process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12723:
URL: https://github.com/apache/dolphinscheduler/issues/12723#issuecomment-1378069648
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #12723: [Improvement][dolphinscheduler-api] Check valid file parameter when defining process
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #12723: [Improvement][dolphinscheduler-api] Check valid file parameter when defining process
URL: https://github.com/apache/dolphinscheduler/issues/12723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #12723: [Improvement][dolphinscheduler-api] Check valid file parameter when defining process
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #12723:
URL: https://github.com/apache/dolphinscheduler/issues/12723#issuecomment-1305166324
> @SbloodyS Please assign me and label `3.2.0` which is as same as #12552
I've labeled it as `3.1.2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on issue #12723: [Improvement][API] Check valid file parameter when defining process
Posted by GitBox <gi...@apache.org>.
Radeity commented on issue #12723:
URL: https://github.com/apache/dolphinscheduler/issues/12723#issuecomment-1304414583
@SbloodyS Please assign me and label `3.2.0` which is as same as https://github.com/apache/dolphinscheduler/issues/12578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12723: [Improvement][dolphinscheduler-api] Check valid file parameter when defining process
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #12723:
URL: https://github.com/apache/dolphinscheduler/issues/12723#issuecomment-1426520981
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12723: [Improvement][dolphinscheduler-api] Check valid file parameter when defining process
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #12723:
URL: https://github.com/apache/dolphinscheduler/issues/12723#issuecomment-1439261760
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org