[GitHub] [activemq] cshannon commented on a diff in pull request #965: [AMQ-9217] Fix per-destination message audits in IndividualDeadLetterStrategy

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #965:
URL: https://github.com/apache/activemq/pull/965#discussion_r1099228408


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/policy/AbstractDeadLetterStrategy.java:
##########
@@ -108,20 +111,25 @@ public void setExpiration(long expiration) {
         this.expiration = expiration;
     }
 
+
+
     public int getMaxProducersToAudit() {
-        return messageAudit.getMaximumNumberOfProducersToTrack();
+        return this.maxProducersToAudit;
     }
 
     public void setMaxProducersToAudit(int maxProducersToAudit) {
-        messageAudit.setMaximumNumberOfProducersToTrack(maxProducersToAudit);
+        this.maxProducersToAudit = maxProducersToAudit;
     }
 
     public void setMaxAuditDepth(int maxAuditDepth) {
-        messageAudit.setAuditDepth(maxAuditDepth);
+        this.maxAuditDepth = maxAuditDepth;

Review Comment:
   This sets the variable but no longer sets the shared audit so that will break things.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org