You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2019/12/18 17:25:41 UTC

[kudu] branch master updated: KUDU-3027 Some fixing for kudu on aarch64

This is an automated email from the ASF dual-hosted git repository.

adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 441d8bd  KUDU-3027 Some fixing for kudu on aarch64
441d8bd is described below

commit 441d8bdb781786d42ab664813faff15a363cbb5a
Author: huangtianhua <hu...@gmail.com>
AuthorDate: Wed Dec 18 08:07:36 2019 +0000

    KUDU-3027 Some fixing for kudu on aarch64
    
    This changes:
    1. Don't set compiler flag with '-msse4.2' for aarch64
    2. Modify 'LLVM_TARGETS_TO_BUILD' to include AArch64 target
    
    Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
    Reviewed-on: http://gerrit.cloudera.org:8080/14921
    Reviewed-by: Adar Dembo <ad...@cloudera.com>
    Tested-by: Adar Dembo <ad...@cloudera.com>
---
 CMakeLists.txt                  | 5 ++++-
 thirdparty/build-definitions.sh | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 61c33f5..07bf648 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -124,7 +124,10 @@ endif()
 
 # compiler flags that are common across debug/release builds
 #  -msse4.2: Enable sse4.2 compiler intrinsics.
-set(CXX_COMMON_FLAGS "-msse4.2")
+execute_process(COMMAND uname -p OUTPUT_VARIABLE ARCH_NAME)
+if (NOT "${ARCH_NAME}" MATCHES "aarch64")
+  set(CXX_COMMON_FLAGS "-msse4.2")
+endif()
 #  -Wall: Enable all warnings.
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall")
 #  -Wno-sign-compare: suppress warnings for comparison between signed and unsigned
diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index 19a0c87..576007c 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -322,7 +322,7 @@ build_llvm() {
     -DLLVM_INCLUDE_EXAMPLES=OFF \
     -DLLVM_INCLUDE_TESTS=OFF \
     -DLLVM_INCLUDE_UTILS=OFF \
-    -DLLVM_TARGETS_TO_BUILD=X86 \
+    -DLLVM_TARGETS_TO_BUILD="X86;AArch64" \
     -DLLVM_ENABLE_RTTI=ON \
     -DCMAKE_CXX_FLAGS="$CLANG_CXXFLAGS" \
     -DCMAKE_EXE_LINKER_FLAGS="$CLANG_LDFLAGS" \