You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/02 08:39:39 UTC
[GitHub] [flink] klion26 opened a new pull request #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
klion26 opened a new pull request #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614
## What is the purpose of the change
Fix the wrong logic of `NullableSerializer#copy`,
currently, the logic is such as below:
```
public void copy(DataInputView source, DataOutputView target) throws IOException {
boolean isNull = source.readBoolean();
target.writeBoolean(isNull);
if (isNull) {
target.write(padding);
}
else {
originalSerializer.copy(source, target);
}
}
```
we forgot to skip paddings.length bytes when if the padding's length is not 0.
We can correct the logic such as below
```
public void copy(DataInputView source, DataOutputView target) throws IOException {
boolean isNull = deserializeNull(source); // this will skip the padding values.
target.writeBoolean(isNull);
if (isNull) {
target.write(padding);
}
else {
originalSerializer.copy(source, target);
}
}
```
## Verifying this change
Harden the test of `NullalbeSerialierTest#testSerializedCopyAsSequence` by update the test data.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (yes)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157719841) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719841) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607785728
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607785675
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607785728",
"triggerType" : "MANUAL"
}, {
"hash" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157719841) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974)
* 46ca50b48aef1510329307c6e8a327fadf129c5c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607785728",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607785728",
"triggerType" : "MANUAL"
}, {
"hash" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157749996",
"triggerID" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"triggerType" : "PUSH"
}, {
"hash" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6986",
"triggerID" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46ca50b48aef1510329307c6e8a327fadf129c5c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157749996) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6986)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157719841) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607785728",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607785728",
"triggerType" : "MANUAL"
}, {
"hash" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157749996",
"triggerID" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"triggerType" : "PUSH"
}, {
"hash" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6986",
"triggerID" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46ca50b48aef1510329307c6e8a327fadf129c5c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157749996) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6986)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607754952
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607707709
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 (Thu Apr 02 08:43:12 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607961174
Thanks for the fix! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607705969
cc @aljoscha
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-608168277
@aljoscha thanks for the review and merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607755286",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "607785728",
"triggerType" : "MANUAL"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "607785728",
"triggerType" : "MANUAL"
}, {
"hash" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157749996",
"triggerID" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"triggerType" : "PUSH"
}, {
"hash" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6986",
"triggerID" : "46ca50b48aef1510329307c6e8a327fadf129c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/157719841) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974)
* 46ca50b48aef1510329307c6e8a327fadf129c5c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157749996) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6986)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607755286
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719841) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607713063
Good fix! I will wait for Travis or Azure and then merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614#issuecomment-607717232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719841",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
}, {
"hash" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974",
"triggerID" : "6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b182c9437f0b4b51c2d6a27f3e1cd5893b1beb5 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157719841) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha merged pull request #11614:
[FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
Posted by GitBox <gi...@apache.org>.
aljoscha merged pull request #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy
URL: https://github.com/apache/flink/pull/11614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services