You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/02/22 19:55:16 UTC
[kudu-CR] Improve tablet status messages during startup
Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9400
to review the following change.
Change subject: Improve tablet status messages during startup
......................................................................
Improve tablet status messages during startup
Currently while the tablet server is starting, all of the tablets that
are waiting in the 'tablet-open' threadpool have the status 'Tablet
initializing...'. This can be confusing to admins since it sounds like
it is stuck rather than waiting in a queue.
This amends the status messages accordingly.
Change-Id: I72337860e3c4c0a0992c3fb8578e94857529805e
---
M src/kudu/tablet/tablet_replica.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/9400/1
--
To view, visit http://gerrit.cloudera.org:8080/9400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72337860e3c4c0a0992c3fb8578e94857529805e
Gerrit-Change-Number: 9400
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Improve tablet status messages during startup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9400 )
Change subject: Improve tablet status messages during startup
......................................................................
Improve tablet status messages during startup
Currently while the tablet server is starting, all of the tablets that
are waiting in the 'tablet-open' threadpool have the status 'Tablet
initializing...'. This can be confusing to admins since it sounds like
it is stuck rather than waiting in a queue.
This amends the status messages accordingly.
Change-Id: I72337860e3c4c0a0992c3fb8578e94857529805e
Reviewed-on: http://gerrit.cloudera.org:8080/9400
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/tablet_replica.cc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I72337860e3c4c0a0992c3fb8578e94857529805e
Gerrit-Change-Number: 9400
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Improve tablet status messages during startup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9400 )
Change subject: Improve tablet status messages during startup
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72337860e3c4c0a0992c3fb8578e94857529805e
Gerrit-Change-Number: 9400
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:06:25 +0000
Gerrit-HasComments: No