You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2015/08/10 10:25:45 UTC
Review Request 37286: [FALCON-1382] Add a test for feed retention to
make sure that data directory is not deleted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37286/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1382
https://issues.apache.org/jira/browse/FALCON-1382
Repository: falcon-git
Description
-------
We want to add a feed retention test that leads to deletion of all the data. We want to make sure that the directory which contains the data is not deleted. for eg if the data looks like:
/tmp/data/2015-04-01
/tmp/data/2015-04-02
/tmp/data/2015-04-03
And the retention operation deletes all the data then we want to make sure that /tmp/data does not get deleted.
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 628dca1
Diff: https://reviews.apache.org/r/37286/diff/
Testing
-------
Tested on local VM cluster
Thanks,
Paul Isaychuk
Re: Review Request 37286: [FALCON-1382] Add a test for feed retention
to make sure that data directory is not deleted
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37286/#review95278
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Aug. 13, 2015, 6:31 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37286/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 6:31 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1382
> https://issues.apache.org/jira/browse/FALCON-1382
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> We want to add a feed retention test that leads to deletion of all the data. We want to make sure that the directory which contains the data is not deleted. for eg if the data looks like:
> /tmp/data/2015-04-01
> /tmp/data/2015-04-02
> /tmp/data/2015-04-03
> And the retention operation deletes all the data then we want to make sure that /tmp/data does not get deleted.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 628dca1
>
> Diff: https://reviews.apache.org/r/37286/diff/
>
>
> Testing
> -------
>
> Tested on local VM cluster
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 37286: [FALCON-1382] Add a test for feed retention
to make sure that data directory is not deleted
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37286/
-----------------------------------------------------------
(Updated Aug. 13, 2015, 1:31 p.m.)
Review request for Falcon.
Changes
-------
1. Removed "future" dates (which prevent "delete all data" scenarios)
2. added check that root data directory exists
Bugs: FALCON-1382
https://issues.apache.org/jira/browse/FALCON-1382
Repository: falcon-git
Description
-------
We want to add a feed retention test that leads to deletion of all the data. We want to make sure that the directory which contains the data is not deleted. for eg if the data looks like:
/tmp/data/2015-04-01
/tmp/data/2015-04-02
/tmp/data/2015-04-03
And the retention operation deletes all the data then we want to make sure that /tmp/data does not get deleted.
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 628dca1
Diff: https://reviews.apache.org/r/37286/diff/
Testing
-------
Tested on local VM cluster
Thanks,
Paul Isaychuk