[GitHub] [pulsar] BewareMyPower commented on issue #12234: [PIP] Add seek by index feature for consumer

[GitBox <gi...@apache.org>]

BewareMyPower commented on issue #12234:
URL: https://github.com/apache/pulsar/issues/12234#issuecomment-929917416


   Let's move the discussion here. @MarvinCai 
   
   > But not all users will use Index or even BrokerEntryMetadata, while all messages have Timestamp and MessageID, that's a bit different in my opinion. Adding a method that rely on a property might not exist for all users is kind of weird.
   
   I think it's a document issue. If we've documented well for the `seekByIndex` method, there will be nothing confused for users.  Just like we've exposed BrokerEntryMetadata in #11553, the added methods of `Message` also requires broker to enable BrokerEntryMetadata.
   
   https://github.com/apache/pulsar/blob/879e93d07c36567f6ba7792cc9274142ff4c0d74/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Message.java#L274-L282
   
   (Though I think this doc is not well. We should make it clear that which configs should be configured in broker.)
   
   Similarly, The current seek operation by message id also has some restrictions.
   
   https://github.com/apache/pulsar/blob/879e93d07c36567f6ba7792cc9274142ff4c0d74/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java#L586-L587
   
   In conclusion, it provides a solution for users that are eager for message count based seek semantics. At the same time, it doesn't affect existing APIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org