You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/26 21:13:45 UTC

[GitHub] [camel-k] Xxyumi-hub opened a new pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include

Xxyumi-hub opened a new pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-k/pull/1377
 
 
   CAMEL-13704 - https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-13704?filter=allopenissues
   I have created a PR template file for this repo and plan to add the same template to the camel-quarkus repo

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] nicolaferraro commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.

nicolaferraro commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-k/pull/1377#discussion_r399346909

##########
File path: PR-template.txt
##########
@@ -0,0 +1,7 @@
+[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
+[ ] Each commit in the pull request should have a meaningful subject line and body.
+[ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
+[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
+[ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.

Review comment:
Does not apply

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [camel-k] Xxyumi-hub commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.

Xxyumi-hub commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-k/pull/1377#discussion_r399606339
 
 

 ##########
 File path: PR-template.txt
 ##########
 @@ -0,0 +1,7 @@
+[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
+[ ] Each commit in the pull request should have a meaningful subject line and body.
+[ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
+[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
+[ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
+Below are the contribution guidelines:
+https://github.com/apache/camel/blob/master/CONTRIBUTING.md
 
 Review comment:
   Thank you for the feedback! How does the below-proposed changes look?
   
   [ ] Make sure there is a [Github issue](https://github.com/apache/camel-k/issues) filed for the change (before you start working on an issue).  One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-k/latest/developers.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] nicolaferraro commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.

nicolaferraro commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-k/pull/1377#discussion_r399346945
 
 

 ##########
 File path: PR-template.txt
 ##########
 @@ -0,0 +1,7 @@
+[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
 
 Review comment:
   We don't use Jira for this repo, we use github issues

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] nicolaferraro commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.

Review comment:
They are here https://camel.apache.org/camel-k/latest/developers.html

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [camel-k] oscerd commented on issue #1377: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.

oscerd commented on issue #1377: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-k/pull/1377#issuecomment-607059671
 
 
   > Looks good to me but this should go under .github directory and renamed
   
   I mean this should be done here:
   https://github.com/apache/camel-k/blob/master/.github/pull_request_template.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] nicolaferraro commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.

nicolaferraro commented on a change in pull request #1377: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-k/pull/1377#discussion_r399346918
 
 

 ##########
 File path: PR-template.txt
 ##########
 @@ -0,0 +1,7 @@
+[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
+[ ] Each commit in the pull request should have a meaningful subject line and body.
+[ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
 
 Review comment:
   Fix #issuenr is the right format

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] Xxyumi-hub commented on issue #1377: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.

Xxyumi-hub commented on issue #1377: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-k/pull/1377#issuecomment-610487264
 
 
   Updated!! Thank you for the detailed feedback

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services