[GitHub] [druid] clintropolis commented on a change in pull request #10224: Segment backed broadcast join IndexedTable

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10224:
URL: https://github.com/apache/druid/pull/10224#discussion_r466709051



##########
File path: processing/src/main/java/org/apache/druid/segment/join/table/RowBasedIndexedTable.java
##########
@@ -69,10 +68,6 @@ public RowBasedIndexedTable(
     this.keyColumns = keyColumns;
     this.version = version;
 
-    if (new HashSet<>(keyColumns).size() != keyColumns.size()) {

Review comment:
       Ah, no, #9287 refactored the signature from using a `List<String>` to a `Set<String>`, which I think makes this check pointless.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org