You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/06/17 11:05:19 UTC
[jira] Created: (MNG-483) sort out artifact attachment
sort out artifact attachment
----------------------------
Key: MNG-483
URL: http://jira.codehaus.org/browse/MNG-483
Project: Maven 2
Type: Bug
Reporter: Brett Porter
Assigned to: Brett Porter
Priority: Critical
Fix For: 2.0-alpha-3
currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
sort out
- if there is an easier way to achieve this
- how to retain the default source binding, but also how to turn it off
- how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
- how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_43983 ]
Brett Porter commented on MNG-483:
----------------------------------
I think the current code attachment will suffice for now.
I think removing the SNAPSHOT check and letting users add a release profile that the release plugin always uses (but that they can use too) is a good way to do this.
I'm not yet sure how to enable the source binding by default, and how to disable it once enabled. Thoughts?
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Jason Grant (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44289 ]
Jason Grant commented on MNG-483:
---------------------------------
A bit of background with regard to Brett's mention of me looking at the attachment of artifacts, above.
I've been using assembly to produce zip files, and asked questions on IRC about how best to get these across to the local repo so that other project could depend on them. If I understand correctly, Brett suggested an enhancement to AssemblyMojo that will attach all assemblies to the project as artifacts. Then, when the project is installed, these artifacts will wind up in the local repo.
There was some talk of only doing this if the project packaging was of [new] type "assembly", but I think we agreed to do it whatever the packaging is (see below). I'm happy to have a go at this - I'll build it on top of my contribution sent as a patch in http://jira.codehaus.org/browse/MNG-723 if other folk agree.
So just to be clear, my contribution to this issue has quite limited scope. I'm too green to understand some of the content above.
-----------------------
(15:58:29) jasong: [junk snipped] just thinking ahead though - I was going to modify AssemblyMojo to simply attach each archive to the project. Is that a reasonable start, or should I be considering what the project's packaging is?
(16:05:05) brett: jasong: attach away! That's great, because then anyone generating an assembly (even for a jar) will be able to install/deploy it. Thanks!
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_43984 ]
Brett Porter commented on MNG-483:
----------------------------------
tricky thing to watch out for here:
assembly:assembly has an @execute phase="package", but what we want is to bind it to package and have it run after the normal packaging. We will end up running packaging twice. Hmmm.
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Reopened: (MNG-483) sort out artifact attachment
Posted by John Casey <jd...@commonjava.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
think I forgot to modify the lifecycle mappings...and I know something's
wrong with the source attachment stuff I wrote yesterday. gimme a few
mins and I'll sort it out.
Brett Porter (JIRA) wrote:
| [ http://jira.codehaus.org/browse/MNG-483?page=all ]
|
| Brett Porter reopened MNG-483:
| ------------------------------
|
|
| I am getting an extra artifact on normal jar projects, with
- -artifactClassifier.artifactExtension on the end.
|
|
|>sort out artifact attachment
|>----------------------------
|>
|> Key: MNG-483
|> URL: http://jira.codehaus.org/browse/MNG-483
|> Project: Maven 2
|> Type: Bug
|> Reporter: Brett Porter
|> Assignee: John Casey
|> Priority: Blocker
|> Fix For: 2.0-beta-1
|> Attachments: assembly-050814-1.zip
|>
|>
|>currently, there is an attachArtifact call inside the plugin building
the attachment. It imposes a m-a and m-p dependency, as well as an
artifactFactory requirement to be able to construct the artifact to attach.
|>sort out
|>- if there is an easier way to achieve this
|>- how to retain the default source binding, but also how to turn it off
|>- how to make the source binding happen only on "release" (bear in
mind people may not be using the release plugin... a profile was the
original idea)
|>- how to bind assembly similarly
|
|
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFDA1WTK3h2CZwO/4URAuJxAJoCS/JUX8m6B/ZQgZ8XAP+bNCECsACfbcJS
JHAOaklq4PhF+7114QlOuks=
=Rdch
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Reopened: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=all ]
Brett Porter reopened MNG-483:
------------------------------
I am getting an extra artifact on normal jar projects, with -artifactClassifier.artifactExtension on the end.
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Jason Grant (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44464 ]
Jason Grant commented on MNG-483:
---------------------------------
Re (4): My patch does *not* cater for the cliOnly idea; it simply attaches all assemblies as project artifacts as described in #action_44289 above. I'm not game to start making changes to the core lifecycle algorithms until I graduate from novice status!
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44457 ]
Brett Porter commented on MNG-483:
----------------------------------
reponses to http://jira.codehaus.org/browse/MNG-483#action_44258
1) cool
2) how about just having an "attach" parameter on each mojo that can do it? Now that I think about it, that seems much easier.
3) this should tie into (1). So (2) would always default to false, then the super POM would have a profile with the release ID that enables sources and javadocs. I'm almost inclined to leave this out and make people specify it, but put it in the archetypes...
4) I think Jason's patch takes care of this?
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44199 ]
John Casey commented on MNG-483:
--------------------------------
I'm not sure I have enough background on this issue to keep up.
1. How would you activate a profile that introduces the attachment in the case of the release plugin?
2. What do you mean by disabling the source binding once enabled, and in the case of enabling it by default are you talking about some sort of POM addition or something? What's the issue here, exactly?
3. What SNAPSHOT check are you referring to? Determining whether to attach the source artifact based on snapshot vs. not?
4. I like the cliOnly annotation idea, and I think it may have more general applicability.
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44220 ]
Brett Porter commented on MNG-483:
----------------------------------
1) I was thinking a property or ID documented and used by the release plugin specifically for that purpose
2) I want it possible to have the source binding enabled by default, and make it possible to disable it easily from a pom, but this isn't how inheritence has tended to work
3) currently in the source plugin it only generates if it is not a snapshot (as I think it only makes sense to enable this by default as part of the release, actually, not for snapshot generation and normal builds)
4) ok, let's go with that. I tried alternatives and kept coming back to it.
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-483) sort out artifact attachment
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=all ]
John Casey closed MNG-483:
--------------------------
Resolution: Fixed
cliOnly annotation parameter has been changed to @requiresDirectInvocation to reflect potential embedded mode, and to act as a flag like @requiresProject does.
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44524 ]
John Casey commented on MNG-483:
--------------------------------
I've already applied this patch locally...I'll check it in soon, when I can get a good build. Then, we can go from there wrt MNG-735.
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44078 ]
Brett Porter commented on MNG-483:
----------------------------------
1) Jason Grant is looking at implementing the attaching of artifacts during assembly:assembly which is a part of this
2) on my "tricky bit" comment above, this can probably be resolved by having that be @execute phase="package" cliOnly="true" (where cliOnly is a new construct indicating the goal had to be called explicitly to trigger it, instead of during the lifecycle for package). This hearkens back to "reverse lookup of the lifecycle for a goal", so should review that issue first to see whether there are other reasons to beware of here.
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=all ]
Brett Porter updated MNG-483:
-----------------------------
Fix Version: (was: 2.0-alpha-3)
2.0-beta-1
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: Brett Porter
> Priority: Critical
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=all ]
Brett Porter updated MNG-483:
-----------------------------
Priority: Blocker (was: Critical)
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: Brett Porter
> Priority: Blocker
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44465 ]
Brett Porter commented on MNG-483:
----------------------------------
oops, I was looking at the 4th point at the top... sorry!
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-483) sort out artifact attachment
Posted by "Jason Grant (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=all ]
Jason Grant updated MNG-483:
----------------------------
Attachment: assembly-050814-1.zip
I've made the change described in my comment above. Hope it finds its way into svn soon.
Note that this attachment builds on the AssemblyMojo that was contributed in #MNG-723 (the new unpack goal). I'll make a note there too.
I still intend to contribute an integration test for this in the near future.
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "Jason Grant (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44522 ]
Jason Grant commented on MNG-483:
---------------------------------
Would you like me to check my enhancements in to svn? I notice that Daniel Krisher has patched the assembly plugin off the trunk, over in #MNG-735. He is probably unaware of the 'unpack' work (#MNG-723) and I think that Daniels directory patch will have implications for automatic addition of artifacts, as described here; i.e. we probably don't want to add a directory as a project artifact, right?
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-483) sort out artifact attachment
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=all ]
John Casey closed MNG-483:
--------------------------
Resolution: Fixed
see it0051 and it0052 (which I will be creating now)
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
> Attachments: assembly-050814-1.zip
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-483) sort out artifact attachment
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-483?page=comments#action_44258 ]
John Casey commented on MNG-483:
--------------------------------
1. Okay, I get it now...that's easy enough to handle.
2. What about having something like:
<project>
...
<build>
...
<attachments>
<source>true</source>
</attachments>
</build>
</project>
in order to turn on/off source attachments? the values in the attachments stanza could be a free-form DOM or somesuch, with the maven-source-plugin checking for ${project.buildAttachments}.isEnabled( "source" ) or somesuch...and the inheritance assembler could do a DOM merge with local-wins for the child to override the value in the super-pom. WDYT?
3. I'd agree that maybe the super-pom should have a profile inline that specifies the source plugin, and is activated by -DsourceArtifact=true or somesuch. Then, we get away from checking for -SNAPSHOT, and only releases and very explicit usages would activate that profile.
4. will do. Is someone already working on this part (or on the assembly mojo's lack of execution in the package phase)?
> sort out artifact attachment
> ----------------------------
>
> Key: MNG-483
> URL: http://jira.codehaus.org/browse/MNG-483
> Project: Maven 2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Priority: Blocker
> Fix For: 2.0-beta-1
>
>
> currently, there is an attachArtifact call inside the plugin building the attachment. It imposes a m-a and m-p dependency, as well as an artifactFactory requirement to be able to construct the artifact to attach.
> sort out
> - if there is an easier way to achieve this
> - how to retain the default source binding, but also how to turn it off
> - how to make the source binding happen only on "release" (bear in mind people may not be using the release plugin... a profile was the original idea)
> - how to bind assembly similarly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org