[GitHub] [druid] capistrant commented on a change in pull request #11394: Add a new metric query/segments/count that is not emitted by default

[GitBox <gi...@apache.org>]

capistrant commented on a change in pull request #11394:
URL: https://github.com/apache/druid/pull/11394#discussion_r666506325



##########
File path: server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
##########
@@ -369,6 +373,8 @@ private ClusterQueryResult(Sequence<T> sequence, int numQueryServers)
 
       query = scheduler.prioritizeAndLaneQuery(queryPlus, segmentServers);
       queryPlus = queryPlus.withQuery(query);
+      queryPlus = queryPlus.withQueryMetrics(toolChest);
+      queryPlus.getQueryMetrics().reportQueriedSegmentCount(segmentServers.size()).emit(emitter);

Review comment:
       @jihoonson That retry code is unfamiliar to me at this time, `Number of segments that will be touched by the query. If the query has to be retried, the metric will be reported for all retries as well as the original query.` Is that a sane description of the metric in the metrics.md file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org