You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Ethan Rose (Jira)" <ji...@apache.org> on 2020/10/23 16:56:00 UTC
[jira] [Commented] (HDDS-4337) Implement RocksDB options cache for
new datanode DB utilities
[ https://issues.apache.org/jira/browse/HDDS-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219807#comment-17219807 ]
Ethan Rose commented on HDDS-4337:
----------------------------------
From the[ RocksDB DBOptions java documentation| [https://javadoc.io/static/org.rocksdb/rocksdbjni/6.6.4/org/rocksdb/Options.html] []:|https://javadoc.io/static/org.rocksdb/rocksdbjni/6.6.4/org/rocksdb/DBOptions.html]]
??Statistics objects should not be shared between DB instances as it does not use any locks to prevent concurrent updates??
Therefore, the sharing of Options objects done before HDDS-3869 was probably incorrect, since using the same Options object for all DBs meant we were using the same statistics object for all DBs. It does not seem possible to share Options without sharing Statistics, since Statistics are contained in Options. Therefore, this optimization may not be possible to implement.
> Implement RocksDB options cache for new datanode DB utilities
> -------------------------------------------------------------
>
> Key: HDDS-4337
> URL: https://issues.apache.org/jira/browse/HDDS-4337
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Ethan Rose
> Assignee: Ethan Rose
> Priority: Major
>
> HDDS-3869 switched datanodes from using the old database utilities found in the hdds.utils package to the new database utilities in the hdds.utils.db package. Since the datanode RocksDB options cache from HDDS-2283 was implemented in the old utilities package, it is no longer present on the datanodes after HDDS-3869 was merged. This issue aims to add the options cache performance improvement to the new datanode code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org