You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by br...@apache.org on 2010/03/16 04:13:26 UTC

svn commit: r923566 - in /incubator/thrift/trunk: compiler/cpp/src/generate/t_java_generator.cc test/JavaBeansTest.thrift

Author: bryanduxbury
Date: Tue Mar 16 03:13:26 2010
New Revision: 923566

URL: http://svn.apache.org/viewvc?rev=923566&view=rev
Log:
THRIFT-734. java: Can't use primitive types in service definitions for bean generated code

Modified:
    incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc
    incubator/thrift/trunk/test/JavaBeansTest.thrift

Modified: incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc?rev=923566&r1=923565&r2=923566&view=diff
==============================================================================
--- incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc (original)
+++ incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc Tue Mar 16 03:13:26 2010
@@ -2313,7 +2313,7 @@ void t_java_generator::generate_service_
 
     for (fld_iter = fields.begin(); fld_iter != fields.end(); ++fld_iter) {
       f_service_ <<
-        indent() << "args." << (*fld_iter)->get_name() << " = " << (*fld_iter)->get_name() << ";" << endl;
+        indent() << "args.set" << get_cap_name((*fld_iter)->get_name()) << "(" << (*fld_iter)->get_name() << ");" << endl;
     }
 
     f_service_ <<

Modified: incubator/thrift/trunk/test/JavaBeansTest.thrift
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/test/JavaBeansTest.thrift?rev=923566&r1=923565&r2=923566&view=diff
==============================================================================
--- incubator/thrift/trunk/test/JavaBeansTest.thrift (original)
+++ incubator/thrift/trunk/test/JavaBeansTest.thrift Tue Mar 16 03:13:26 2010
@@ -32,3 +32,8 @@ struct OneOfEachBeans {
   10: list<i16> i16_list,
   11: list<i64> i64_list
 }
+
+
+service Service {
+  i64 mymethod(i64 blah);
+}
\ No newline at end of file