You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/08/02 12:42:49 UTC
[GitHub] [cordova-lib] erisu opened a new pull request, #895: feat: deprecate osx & windows platform
erisu opened a new pull request, #895:
URL: https://github.com/apache/cordova-lib/pull/895
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
osx, windows
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Deprecate OSX and Windows platform.
### Description
<!-- Describe your changes in detail -->
Set the deprecation flag for OSX and Windows platform.
This can be released in minor release as a notice and then in 12.0.0 remove completely?
### Testing
<!-- Please describe in detail how you tested your changes. -->
- n/a
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
- was already deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] erisu commented on pull request #895: feat: deprecate osx & windows platform
Posted by GitBox <gi...@apache.org>.
erisu commented on PR #895:
URL: https://github.com/apache/cordova-lib/pull/895#issuecomment-1202463836
Actually, this PR can be closed for the two individual PRs I now see already submited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] erisu closed pull request #895: feat: deprecate osx & windows platform
Posted by GitBox <gi...@apache.org>.
erisu closed pull request #895: feat: deprecate osx & windows platform
URL: https://github.com/apache/cordova-lib/pull/895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] codecov-commenter commented on pull request #895: feat: deprecate osx & windows platform
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #895:
URL: https://github.com/apache/cordova-lib/pull/895#issuecomment-1202464236
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/895?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#895](https://codecov.io/gh/apache/cordova-lib/pull/895?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3dae44d) into [master](https://codecov.io/gh/apache/cordova-lib/commit/42b45691d88a79317c17bdc3f05f86c32cb8a12e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (42b4569) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 3dae44d differs from pull request most recent head bd4d2f8. Consider uploading reports for the commit bd4d2f8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #895 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 46 46
Lines 2123 2123
=======================================
Hits 1874 1874
Misses 249 249
```
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org