You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by xi...@apache.org on 2021/03/05 07:00:20 UTC
[shardingsphere] branch master updated: Remove useless code (#9597)
This is an automated email from the ASF dual-hosted git repository.
xiaoyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 3fe7ace Remove useless code (#9597)
3fe7ace is described below
commit 3fe7ace759592bc6a9637d513abc3d60369eef69
Author: Haoran Meng <me...@gmail.com>
AuthorDate: Fri Mar 5 14:59:52 2021 +0800
Remove useless code (#9597)
---
.../governance/core/registry/RegistryCenter.java | 19 +++++--------------
.../governance/core/registry/RegistryCenterNode.java | 16 ++++++++--------
2 files changed, 13 insertions(+), 22 deletions(-)
diff --git a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
index 32c242e..5aef11a 100644
--- a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
+++ b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenter.java
@@ -171,15 +171,6 @@ public final class RegistryCenter {
public void persistRuleConfigurations(final String schemaName, final Collection<RuleConfiguration> ruleConfigurations) {
repository.persist(node.getRulePath(schemaName), YamlEngine.marshal(createYamlRootRuleConfigurations(schemaName, ruleConfigurations)));
}
-
- private void cacheRuleConfigurations(final String schemaName, final Collection<RuleConfiguration> ruleConfigurations) {
- String cacheId = registryCacheManager.cache(node.getRulePath(schemaName), YamlEngine.marshal(createYamlRootRuleConfigurations(schemaName, ruleConfigurations)));
- StartScalingEvent event = new StartScalingEvent(schemaName,
- repository.get(node.getMetadataDataSourcePath(schemaName)),
- repository.get(node.getRulePath(schemaName)),
- registryCacheManager.loadCache(node.getRulePath(schemaName), cacheId), cacheId);
- ShardingSphereEventBus.getInstance().post(event);
- }
private YamlRootRuleConfigurations createYamlRootRuleConfigurations(final String schemaName, final Collection<RuleConfiguration> ruleConfigurations) {
Collection<RuleConfiguration> configs = new LinkedList<>();
@@ -361,7 +352,7 @@ public final class RegistryCenter {
/**
* persist data source configurations.
*
- * @param event Data source added event.
+ * @param event Data source added event
*/
@Subscribe
public synchronized void renew(final DataSourceAddedEvent event) {
@@ -371,7 +362,7 @@ public final class RegistryCenter {
/**
* Change data source configurations.
*
- * @param event Data source altered event.
+ * @param event Data source altered event
*/
@Subscribe
public synchronized void renew(final DataSourceAlteredEvent event) {
@@ -381,7 +372,7 @@ public final class RegistryCenter {
/**
* Persist rule configurations.
*
- * @param event rule configurations altered event.
+ * @param event rule configurations altered event
*/
@Subscribe
public synchronized void renew(final RuleConfigurationsAlteredEvent event) {
@@ -392,7 +383,7 @@ public final class RegistryCenter {
/**
* Persist meta data.
*
- * @param event meta data created event.
+ * @param event meta data created event
*/
@Subscribe
public synchronized void renew(final MetaDataCreatedEvent event) {
@@ -422,7 +413,7 @@ public final class RegistryCenter {
/**
* Persist schema.
*
- * @param event schema altered event.
+ * @param event schema altered event
*/
@Subscribe
public synchronized void renew(final SchemaAlteredEvent event) {
diff --git a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenterNode.java b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenterNode.java
index b43e708..7b0e340 100644
--- a/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenterNode.java
+++ b/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/registry/RegistryCenterNode.java
@@ -294,8 +294,8 @@ public final class RegistryCenterNode {
/**
* Get all schema config paths.
*
- * @param schemaNames schema names.
- * @return config paths list.
+ * @param schemaNames schema names
+ * @return config paths list
*/
public Collection<String> getAllSchemaConfigPaths(final Collection<String> schemaNames) {
Collection<String> result = new ArrayList<>(Collections.singleton(getMetadataNodePath()));
@@ -320,8 +320,8 @@ public final class RegistryCenterNode {
/**
* Get all metadata schema paths.
*
- * @param schemaNames schema names.
- * @return list of schema path.
+ * @param schemaNames schema names
+ * @return list of schema path
*/
public Collection<String> getAllMetadataSchemaPaths(final Collection<String> schemaNames) {
return schemaNames.stream().map(this::getMetadataSchemaPath).collect(Collectors.toList());
@@ -330,8 +330,8 @@ public final class RegistryCenterNode {
/**
* Get all rule paths.
*
- * @param schemaNames schema names.
- * @return list of rule path.
+ * @param schemaNames schema names
+ * @return list of rule path
*/
public Collection<String> getAllRulePaths(final Collection<String> schemaNames) {
return schemaNames.stream().map(this::getRulePath).collect(Collectors.toList());
@@ -340,8 +340,8 @@ public final class RegistryCenterNode {
/**
* Get all data source paths.
*
- * @param schemaNames schema names.
- * @return list of data source path.
+ * @param schemaNames schema names
+ * @return list of data source path
*/
public Collection<String> getAllDataSourcePaths(final Collection<String> schemaNames) {
return schemaNames.stream().map(this::getMetadataDataSourcePath).collect(Collectors.toList());