[jira] [Commented] (PHOENIX-6114) Create shaded phoenix-pherf and remove lib dir from assembly

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278650#comment-17278650 ] 

ASF GitHub Bot commented on PHOENIX-6114:
-----------------------------------------

stoty opened a new pull request #1131:
URL: https://github.com/apache/phoenix/pull/1131


   …mbly
   
   remove pherf-cluster.py
   remove phoenix-pherf-minimal shaded jar
   remove /lib dir from assembly
   remove /dev library from assemby
   shade phoenix-pherf instead
   move phoenix-pherf.jar to root
   update scripts for new jar names and paths


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create shaded phoenix-pherf and remove lib dir from assembly
> ------------------------------------------------------------
>
>                 Key: PHOENIX-6114
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6114
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> The Phoenix assembly has a poorly maintained lib directory, with dependencies that we are for submodules that have since been moved to phoenix-queryserver. 
> The core phoenix jars are shaded, and do not or use the libraries here.
> phoenix-tracing-webapp is not included in the assembly, and thus does not need dependencies there.
> That leaves phoenix-pherf as a possible consumer of these dependencies.
> I propose building refactoring phoenix-pherf similarly to phoenix-queryserver, as a mostly self-contained shaded JAR, that only depends on phoenix-client, and has the rest of its dependencies shaded in.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)