You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Tomas Restrepo (JIRA)" <qp...@incubator.apache.org> on 2007/01/03 22:32:27 UTC

[jira] Created: (QPID-246) Custom Exception types should be serializable

Custom Exception types should be serializable
---------------------------------------------

                 Key: QPID-246
                 URL: https://issues.apache.org/jira/browse/QPID-246
             Project: Qpid
          Issue Type: Improvement
          Components: Dot Net Client
         Environment: .NET 1.1
            Reporter: Tomas Restrepo
            Priority: Minor


The custom Exception types defined by the .NET client should be serializable to ensure the client is easy to use from as many environments as possible. This is pretty important if used in contexts where COM interop is involved, including Enterprise Services.

This involves:
- Adding [Serializable] attributes to exception classes
- Implementing a serialization constructor
- Implemente ISerializable.GetObjectData() if needed.

Patch to fix this follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (QPID-246) Custom Exception types should be serializable

Posted by "Rupert Smith (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462452 ] 

Rupert Smith commented on QPID-246:
-----------------------------------

Tried the patch. Looks fine. Will get someone to commit it.

> Custom Exception types should be serializable
> ---------------------------------------------
>
>                 Key: QPID-246
>                 URL: https://issues.apache.org/jira/browse/QPID-246
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Dot Net Client
>         Environment: .NET 1.1
>            Reporter: Tomas Restrepo
>            Priority: Minor
>         Attachments: SerializableExceptions.diff
>
>
> The custom Exception types defined by the .NET client should be serializable to ensure the client is easy to use from as many environments as possible. This is pretty important if used in contexts where COM interop is involved, including Enterprise Services.
> This involves:
> - Adding [Serializable] attributes to exception classes
> - Implementing a serialization constructor
> - Implemente ISerializable.GetObjectData() if needed.
> Patch to fix this follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (QPID-246) Custom Exception types should be serializable

Posted by "Rupert Smith (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462537 ] 

Rupert Smith commented on QPID-246:
-----------------------------------

Tried the second patch. Looks fine too.

> Custom Exception types should be serializable
> ---------------------------------------------
>
>                 Key: QPID-246
>                 URL: https://issues.apache.org/jira/browse/QPID-246
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Dot Net Client
>         Environment: .NET 1.1
>            Reporter: Tomas Restrepo
>            Priority: Minor
>         Attachments: QPID-246-2.diff, SerializableExceptions.diff
>
>
> The custom Exception types defined by the .NET client should be serializable to ensure the client is easy to use from as many environments as possible. This is pretty important if used in contexts where COM interop is involved, including Enterprise Services.
> This involves:
> - Adding [Serializable] attributes to exception classes
> - Implementing a serialization constructor
> - Implemente ISerializable.GetObjectData() if needed.
> Patch to fix this follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (QPID-246) Custom Exception types should be serializable

Posted by "Robert Greig (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Greig resolved QPID-246.
-------------------------------

       Resolution: Fixed
    Fix Version/s: M2

Committed svn revision 492963

> Custom Exception types should be serializable
> ---------------------------------------------
>
>                 Key: QPID-246
>                 URL: https://issues.apache.org/jira/browse/QPID-246
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Dot Net Client
>         Environment: .NET 1.1
>            Reporter: Tomas Restrepo
>            Priority: Minor
>             Fix For: M2
>
>         Attachments: QPID-246-2.diff, SerializableExceptions.diff
>
>
> The custom Exception types defined by the .NET client should be serializable to ensure the client is easy to use from as many environments as possible. This is pretty important if used in contexts where COM interop is involved, including Enterprise Services.
> This involves:
> - Adding [Serializable] attributes to exception classes
> - Implementing a serialization constructor
> - Implemente ISerializable.GetObjectData() if needed.
> Patch to fix this follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (QPID-246) Custom Exception types should be serializable

Posted by "Tomas Restrepo (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomas Restrepo updated QPID-246:
--------------------------------

    Attachment: SerializableExceptions.diff

> Custom Exception types should be serializable
> ---------------------------------------------
>
>                 Key: QPID-246
>                 URL: https://issues.apache.org/jira/browse/QPID-246
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Dot Net Client
>         Environment: .NET 1.1
>            Reporter: Tomas Restrepo
>            Priority: Minor
>         Attachments: SerializableExceptions.diff
>
>
> The custom Exception types defined by the .NET client should be serializable to ensure the client is easy to use from as many environments as possible. This is pretty important if used in contexts where COM interop is involved, including Enterprise Services.
> This involves:
> - Adding [Serializable] attributes to exception classes
> - Implementing a serialization constructor
> - Implemente ISerializable.GetObjectData() if needed.
> Patch to fix this follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (QPID-246) Custom Exception types should be serializable

Posted by "Tomas Restrepo (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomas Restrepo updated QPID-246:
--------------------------------

    Attachment: QPID-246-2.diff

> Custom Exception types should be serializable
> ---------------------------------------------
>
>                 Key: QPID-246
>                 URL: https://issues.apache.org/jira/browse/QPID-246
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Dot Net Client
>         Environment: .NET 1.1
>            Reporter: Tomas Restrepo
>            Priority: Minor
>         Attachments: QPID-246-2.diff, SerializableExceptions.diff
>
>
> The custom Exception types defined by the .NET client should be serializable to ensure the client is easy to use from as many environments as possible. This is pretty important if used in contexts where COM interop is involved, including Enterprise Services.
> This involves:
> - Adding [Serializable] attributes to exception classes
> - Implementing a serialization constructor
> - Implemente ISerializable.GetObjectData() if needed.
> Patch to fix this follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (QPID-246) Custom Exception types should be serializable

Posted by "Tomas Restrepo (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462530 ] 

Tomas Restrepo commented on QPID-246:
-------------------------------------

Noticed that the original patch misses a bunch of custom exception classes (as they were derived from others). Submitting a second patch that complements the first one to fix the remaining exception classes. Hopefully this gets all of them.

> Custom Exception types should be serializable
> ---------------------------------------------
>
>                 Key: QPID-246
>                 URL: https://issues.apache.org/jira/browse/QPID-246
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Dot Net Client
>         Environment: .NET 1.1
>            Reporter: Tomas Restrepo
>            Priority: Minor
>         Attachments: SerializableExceptions.diff
>
>
> The custom Exception types defined by the .NET client should be serializable to ensure the client is easy to use from as many environments as possible. This is pretty important if used in contexts where COM interop is involved, including Enterprise Services.
> This involves:
> - Adding [Serializable] attributes to exception classes
> - Implementing a serialization constructor
> - Implemente ISerializable.GetObjectData() if needed.
> Patch to fix this follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira