You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pierre Goiffon (Created) (JIRA)" <ji...@apache.org> on 2011/11/14 11:16:51 UTC
[jira] [Created] (WICKET-4224) DataTable markup : change SPAN to
DIV
DataTable markup : change SPAN to DIV
-------------------------------------
Key: WICKET-4224
URL: https://issues.apache.org/jira/browse/WICKET-4224
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Affects Versions: 1.5.2, 1.4.19
Reporter: Pierre Goiffon
When creating a DataTable, you get SPAN in each TH (HeadersToolbar.html) and TD (DataTable.html). When you have to insert block elements in your TD, it's a problem because a block element can't be inserted in an inline element such as SPAN.
For exemple the following html is not valid :
<td><span><div>...
I'm asking for a change in both HTML to get DIV instead of SPAN.
Existing apps would only be affected through CSS selectors (and possibly JS), if they have such ones. Must be very rare.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4224) DataTable markup : change SPAN to
DIV
Posted by "Pierre Goiffon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149549#comment-13149549 ]
Pierre Goiffon commented on WICKET-4224:
----------------------------------------
Martin, I could not agree more :)
> DataTable markup : change SPAN to DIV
> -------------------------------------
>
> Key: WICKET-4224
> URL: https://issues.apache.org/jira/browse/WICKET-4224
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.19, 1.5.2
> Reporter: Pierre Goiffon
>
> When creating a DataTable, you get SPAN in each TH (HeadersToolbar.html) and TD (DataTable.html). When you have to insert block elements in your TD, it's a problem because a block element can't be inserted in an inline element such as SPAN.
> For exemple the following html is not valid :
> <td><span><div>...
> I'm asking for a change in both HTML to get DIV instead of SPAN.
> Existing apps would only be affected through CSS selectors (and possibly JS), if they have such ones. Must be very rare.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4224) DataTable markup : change SPAN to
DIV
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440273#comment-13440273 ]
Martin Grigorov commented on WICKET-4224:
-----------------------------------------
The change is reverted for HeaderToolbar.html because of the reasons explained in WICKET-4710.
If block elements are needed in the headers then the developer has to provide custom markup for the toolbar.
> DataTable markup : change SPAN to DIV
> -------------------------------------
>
> Key: WICKET-4224
> URL: https://issues.apache.org/jira/browse/WICKET-4224
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.19, 1.5.2
> Reporter: Pierre Goiffon
> Assignee: Emond Papegaaij
> Fix For: 6.0.0-beta1
>
> Attachments: 0001-WICKET-4224-replace-spans-with-wicket-container-in-D.patch
>
>
> When creating a DataTable, you get SPAN in each TH (HeadersToolbar.html) and TD (DataTable.html). When you have to insert block elements in your TD, it's a problem because a block element can't be inserted in an inline element such as SPAN.
> For exemple the following html is not valid :
> <td><span><div>...
> I'm asking for a change in both HTML to get DIV instead of SPAN.
> Existing apps would only be affected through CSS selectors (and possibly JS), if they have such ones. Must be very rare.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4224) DataTable markup : change SPAN to
DIV
Posted by "Martin Grigorov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4224:
------------------------------------
Fix Version/s: 1.6.0
Set the Fix version to 1.6.0 because changing this may break quietly someone's application layout.
> DataTable markup : change SPAN to DIV
> -------------------------------------
>
> Key: WICKET-4224
> URL: https://issues.apache.org/jira/browse/WICKET-4224
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.19, 1.5.2
> Reporter: Pierre Goiffon
> Fix For: 1.6.0
>
>
> When creating a DataTable, you get SPAN in each TH (HeadersToolbar.html) and TD (DataTable.html). When you have to insert block elements in your TD, it's a problem because a block element can't be inserted in an inline element such as SPAN.
> For exemple the following html is not valid :
> <td><span><div>...
> I'm asking for a change in both HTML to get DIV instead of SPAN.
> Existing apps would only be affected through CSS selectors (and possibly JS), if they have such ones. Must be very rare.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4224) DataTable markup : change SPAN to
DIV
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149533#comment-13149533 ]
Martin Grigorov commented on WICKET-4224:
-----------------------------------------
Maybe it is even better to use <wicket:container> instead for the cell item.
> DataTable markup : change SPAN to DIV
> -------------------------------------
>
> Key: WICKET-4224
> URL: https://issues.apache.org/jira/browse/WICKET-4224
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.19, 1.5.2
> Reporter: Pierre Goiffon
>
> When creating a DataTable, you get SPAN in each TH (HeadersToolbar.html) and TD (DataTable.html). When you have to insert block elements in your TD, it's a problem because a block element can't be inserted in an inline element such as SPAN.
> For exemple the following html is not valid :
> <td><span><div>...
> I'm asking for a change in both HTML to get DIV instead of SPAN.
> Existing apps would only be affected through CSS selectors (and possibly JS), if they have such ones. Must be very rare.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4224) DataTable markup : change SPAN to
DIV
Posted by "Emond Papegaaij (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij updated WICKET-4224:
------------------------------------
Attachment: 0001-WICKET-4224-replace-spans-with-wicket-container-in-D.patch
This patch replaces the spans with wicket:container. I've also replaced the spans in NavigationToolbar.html and NoRecordsToolbar.html.
> DataTable markup : change SPAN to DIV
> -------------------------------------
>
> Key: WICKET-4224
> URL: https://issues.apache.org/jira/browse/WICKET-4224
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.19, 1.5.2
> Reporter: Pierre Goiffon
> Fix For: 6.0.0
>
> Attachments: 0001-WICKET-4224-replace-spans-with-wicket-container-in-D.patch
>
>
> When creating a DataTable, you get SPAN in each TH (HeadersToolbar.html) and TD (DataTable.html). When you have to insert block elements in your TD, it's a problem because a block element can't be inserted in an inline element such as SPAN.
> For exemple the following html is not valid :
> <td><span><div>...
> I'm asking for a change in both HTML to get DIV instead of SPAN.
> Existing apps would only be affected through CSS selectors (and possibly JS), if they have such ones. Must be very rare.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4224) DataTable markup : change SPAN to
DIV
Posted by "Emond Papegaaij (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij resolved WICKET-4224.
-------------------------------------
Resolution: Fixed
Assignee: Emond Papegaaij
Patch is applied
> DataTable markup : change SPAN to DIV
> -------------------------------------
>
> Key: WICKET-4224
> URL: https://issues.apache.org/jira/browse/WICKET-4224
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.19, 1.5.2
> Reporter: Pierre Goiffon
> Assignee: Emond Papegaaij
> Fix For: 6.0.0
>
> Attachments: 0001-WICKET-4224-replace-spans-with-wicket-container-in-D.patch
>
>
> When creating a DataTable, you get SPAN in each TH (HeadersToolbar.html) and TD (DataTable.html). When you have to insert block elements in your TD, it's a problem because a block element can't be inserted in an inline element such as SPAN.
> For exemple the following html is not valid :
> <td><span><div>...
> I'm asking for a change in both HTML to get DIV instead of SPAN.
> Existing apps would only be affected through CSS selectors (and possibly JS), if they have such ones. Must be very rare.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira