[GitHub] [cloudstack] shwstppr commented on a change in pull request #6130: Router health check notification mail to show router name next to UUID

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #6130:
URL: https://github.com/apache/cloudstack/pull/6130#discussion_r828917771



##########
File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -1215,7 +1215,7 @@ private void handleFailingChecks(DomainRouterVO router, List<String> failingChec
             return;
         }
 
-        String alertMessage = "Health checks failed: " + failingChecks.size() + " failing checks on router " + router.getUuid();
+        String alertMessage = String.format("Health checks failed: %d failing checks on router %s (UUID:%s)", failingChecks.size(), router.getName(), router.getUuid());
         _alertMgr.sendAlert(AlertType.ALERT_TYPE_DOMAIN_ROUTER, router.getDataCenterId(), router.getPodIdToDeployIn(),
                 alertMessage, alertMessage);
         s_logger.warn(alertMessage + ". Checking failed health checks to see if router needs recreate");

Review comment:
       @DaanHoogland should we add name in alert message (generated below) as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org