You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2017/06/02 11:17:42 UTC

Review Request 59744: LENS-1430 : Expressions are not getting resolved correctly in union query

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59744/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1430
    https://issues.apache.org/jira/browse/LENS-1430


Repository: lens


Description
-------

Expressions are not getting resolved correctly for the below case
 "case when expr1 = 0 then 0 else expr2 * 100 / expr1 end"
expr1 is answerable by Candidate1 and Candidate2
expr2 is answerable by Candidate1


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 7cad400 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java 9422a5c 
  lens-cube/src/test/resources/schema/cubes/base/basecube.xml 55099c8 
  lens-cube/src/test/resources/schema/cubes/base/testcube.xml f123341 
  lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml 69eda6d 
  lens-cube/src/test/resources/schema/facts/union_join_ctx_fact1.xml d5ac70a 
  lens-cube/src/test/resources/schema/facts/union_join_ctx_fact3.xml 27e859e 
  lens-cube/src/test/resources/schema/facts/union_join_ctx_fact4.xml e69de29 


Diff: https://reviews.apache.org/r/59744/diff/1/


Testing
-------


Thanks,

Sushil Mohanty


Re: Review Request 59744: LENS-1430 : Expressions are not getting resolved correctly in union query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59744/#review176901
-----------------------------------------------------------


Ship it!




Ship It!

- Rajat Khandelwal


On June 2, 2017, 4:47 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59744/
> -----------------------------------------------------------
> 
> (Updated June 2, 2017, 4:47 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1430
>     https://issues.apache.org/jira/browse/LENS-1430
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Expressions are not getting resolved correctly for the below case
>  "case when expr1 = 0 then 0 else expr2 * 100 / expr1 end"
> expr1 is answerable by Candidate1 and Candidate2
> expr2 is answerable by Candidate1
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 7cad400 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java 9422a5c 
>   lens-cube/src/test/resources/schema/cubes/base/basecube.xml 55099c8 
>   lens-cube/src/test/resources/schema/cubes/base/testcube.xml f123341 
>   lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml 69eda6d 
>   lens-cube/src/test/resources/schema/facts/union_join_ctx_fact1.xml d5ac70a 
>   lens-cube/src/test/resources/schema/facts/union_join_ctx_fact3.xml 27e859e 
>   lens-cube/src/test/resources/schema/facts/union_join_ctx_fact4.xml e69de29 
> 
> 
> Diff: https://reviews.apache.org/r/59744/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>