You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jb...@apache.org on 2009/01/06 22:39:05 UTC

svn commit: r732128 - /geronimo/server/branches/2.1/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp

Author: jbohn
Date: Tue Jan  6 13:39:05 2009
New Revision: 732128

URL: http://svn.apache.org/viewvc?rev=732128&view=rev
Log:
remove unnecessary eval statement from sql portlet

Modified:
    geronimo/server/branches/2.1/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp

Modified: geronimo/server/branches/2.1/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp?rev=732128&r1=732127&r2=732128&view=diff
==============================================================================
--- geronimo/server/branches/2.1/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp (original)
+++ geronimo/server/branches/2.1/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp Tue Jan  6 13:39:05 2009
@@ -28,17 +28,17 @@
 var <portlet:namespace/>requiredFields2 = new Array("sqlStmts");
 
 function <portlet:namespace/>validateForm1(){
-    var action = eval("document.forms[<portlet:namespace/>formName].elements['action']");
+    var action = document.forms[<portlet:namespace/>formName].elements['action'];
     action.value="Create";
     return textElementsNotEmpty(<portlet:namespace/>formName, <portlet:namespace/>requiredFields);
 }
 function <portlet:namespace/>validateForm2(){
-    var action = eval("document.forms[<portlet:namespace/>formName].elements['action']");
+    var action = document.forms[<portlet:namespace/>formName].elements['action'];
     action.value="Delete";
     return confirm('<fmt:message key="internaldb.runSQLNormal.reallyDeleteDatabase"/>')
 }
 function <portlet:namespace/>validateForm3(){
-    var action = eval("document.forms[<portlet:namespace/>formName].elements['action']");
+    var action = document.forms[<portlet:namespace/>formName].elements['action'];
     action.value="Run SQL";
     return textElementsNotEmpty(<portlet:namespace/>formName, <portlet:namespace/>requiredFields2);
 }