You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/29 13:01:05 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Pearl1594 opened a new pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165
### Description
A destroyed VM when attempted to be started (using the bulk action support in the UI), results in a successful operation, however, the VM doesn't actually start. This PR fixes the false positive result shown in the above mentioned condition
VM continues to remain in destroyed state - but a success response is returned
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tried starting an instance in destroyed state:
```
2021-06-29 12:57:51,609 WARN [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-5:ctx-da4601fa job-52/job-54 ctx-cc08e96e) (logid:08e57fcb) VM VM instance {"id": "3", "name": "i-2-3-VM", "uuid": "4213c3d9-72a8-4201-96c4-003e2c2f845b", "type"="User"} is not in a state to be started: Destroyed
2021-06-29 12:57:51,610 INFO [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-5:ctx-da4601fa job-52/job-54 ctx-cc08e96e) (logid:08e57fcb) Caught CloudRuntimeException, returning job failed com.cloud.utils.exception.CloudRuntimeException: Cannot start VM: VM instance {"id": "3", "name": "i-2-3-VM", "uuid": "4213c3d9-72a8-4201-96c4-003e2c2f845b", "type"="User"} in Destroyed state
2021-06-29 12:57:51,613 DEBUG [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-5:ctx-da4601fa job-52/job-54 ctx-cc08e96e) (logid:08e57fcb) Done executing VM work job: com.cloud.vm.VmWorkStart{"dcId":0,"rawParams":{"VmPassword":"rO0ABXQADnNhdmVkX3Bhc3N3b3Jk"},"userId":2,"accountId":2,"vmId":3,"handlerName":"VirtualMachineManagerImpl"}
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#discussion_r663903003
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -881,8 +881,9 @@ protected boolean checkWorkItems(final VMInstanceVO vm, final State state) throw
}
if (state != State.Stopped) {
- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
- return null;
+ String msg = String.format("Cannot start VM: %s in %s state", vm, state);
Review comment:
`vm` is of type `VMInstanceVO`; This class implements a `toString()` like `VM instance...`, so the final message will be:
`Cannot start VM: VM instance...`.
We could remove the `VM:` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874206372
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-871909041
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874142705
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874127271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870641097
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874127271
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-871898153
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874127139
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#discussion_r663944636
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -881,8 +881,9 @@ protected boolean checkWorkItems(final VMInstanceVO vm, final State state) throw
}
if (state != State.Stopped) {
- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
- return null;
+ String msg = String.format("Cannot start VM: %s in %s state", vm, state);
Review comment:
keen observation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-871908731
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#discussion_r660909798
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -881,8 +881,8 @@ protected boolean checkWorkItems(final VMInstanceVO vm, final State state) throw
}
if (state != State.Stopped) {
- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
- return null;
+ s_logger.warn("VM " + vm + " is not in a state to be started: " + state);
+ throw new CloudRuntimeException(String.format("Cannot start VM: %s in %s state", vm, state));
Review comment:
We could unify these messages in a String var (with String.format).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870699595
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874397326
<b>Trillian test result (tid-1205)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33120 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5165-t1205-kvm-centos7.zip
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-872336277
<b>Trillian test result (tid-1179)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37293 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5165-t1179-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 72 look OK, 16 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
test_list_vms_metrics | `Error` | 0.24 | test_metrics_api.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
test_delete_account | `Error` | 0.46 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 1.12 | test_network.py
test_deploy_vm_l2network | `Error` | 1.11 | test_network.py
test_l2network_restart | `Error` | 2.19 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.41 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 1.25 | test_network.py
test_reboot_router | `Failure` | 0.04 | test_network.py
test_releaseIP | `Error` | 0.44 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 0.49 | test_network.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 1802.89 | test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_nic_secondaryip_add_remove | `Failure` | 0.04 | test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
test_09_project_suspend | `Error` | 1.08 | test_projects.py
test_10_project_activation | `Error` | 1.06 | test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-872351651
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-872351798
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-871172665
<b>Trillian test result (tid-1160)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51927 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5165-t1160-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 84 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 224.01 | test_kubernetes_clusters.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 347.60 | test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 537.61 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 537.63 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 474.42 | test_vpc_redundant.py
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 380.14 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-877056930
Merging this based on LGTMs, manual and smoke tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-871898616
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#discussion_r664263489
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -881,8 +881,9 @@ protected boolean checkWorkItems(final VMInstanceVO vm, final State state) throw
}
if (state != State.Stopped) {
- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
- return null;
+ String msg = String.format("Cannot start %s in %s state", vm, state);
+ s_logger.warn(msg);
+ throw new CloudRuntimeException(msg);
Review comment:
code LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870753592
<b>Trillian Build Failed (tid-1159)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870579620
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870579620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874127139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870755993
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870580026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-872699479
<b>Trillian test result (tid-1190)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43413 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5165-t1190-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 336.32 | test_routers_network_ops.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 523.40 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 507.98 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#discussion_r663903003
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -881,8 +881,9 @@ protected boolean checkWorkItems(final VMInstanceVO vm, final State state) throw
}
if (state != State.Stopped) {
- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
- return null;
+ String msg = String.format("Cannot start VM: %s in %s state", vm, state);
Review comment:
`vm` is of type `VMInstanceVO`; This class implements a `toString()` like `VM instance...`, so the final message will be:
`Cannot start VM: VM instance...`.
We could remove the `VM:` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#discussion_r664263489
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -881,8 +881,9 @@ protected boolean checkWorkItems(final VMInstanceVO vm, final State state) throw
}
if (state != State.Stopped) {
- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
- return null;
+ String msg = String.format("Cannot start %s in %s state", vm, state);
+ s_logger.warn(msg);
+ throw new CloudRuntimeException(msg);
Review comment:
code LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870640222
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870677418
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#discussion_r661509300
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -881,8 +881,8 @@ protected boolean checkWorkItems(final VMInstanceVO vm, final State state) throw
}
if (state != State.Stopped) {
- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
- return null;
+ s_logger.warn("VM " + vm + " is not in a state to be started: " + state);
+ throw new CloudRuntimeException(String.format("Cannot start VM: %s in %s state", vm, state));
Review comment:
```suggestion
String msg = String.format("Cannot start VM: %s in %s state", vm, state)
s_logger.warn(msg);
throw new CloudRuntimeException(msg));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#discussion_r663944636
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -881,8 +881,9 @@ protected boolean checkWorkItems(final VMInstanceVO vm, final State state) throw
}
if (state != State.Stopped) {
- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
- return null;
+ String msg = String.format("Cannot start VM: %s in %s state", vm, state);
Review comment:
keen observation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874205956
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870677936
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870580026
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-871908522
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870755627
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5165:
URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-870638623
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org