You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2017/01/09 23:58:11 UTC

[6/6] isis git commit: ISIS-1565: fixes wicket UI so that DROPDOWN position for mixin actions (as per @MemberOrder) continues to be honoured if it is not overridden in layout.xml

ISIS-1565: fixes wicket UI so that DROPDOWN position for mixin actions (as per @MemberOrder) continues to be honoured if it is not overridden in layout.xml


Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/a91d0a84
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/a91d0a84
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/a91d0a84

Branch: refs/heads/master
Commit: a91d0a840f4aa738702c44d0eaff7570ceb4d3e6
Parents: 7c8cd33
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Mon Jan 9 23:53:04 2017 +0000
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Mon Jan 9 23:53:04 2017 +0000

----------------------------------------------------------------------
 .../metamodel/facets/actions/layout/ActionLayoutFacetFactory.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/isis/blob/a91d0a84/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/layout/ActionLayoutFacetFactory.java
----------------------------------------------------------------------
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/layout/ActionLayoutFacetFactory.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/layout/ActionLayoutFacetFactory.java
index 5803825..6b2251e 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/layout/ActionLayoutFacetFactory.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/layout/ActionLayoutFacetFactory.java
@@ -188,7 +188,7 @@ public class ActionLayoutFacetFactory extends FacetFactoryAbstract implements Co
 
         // position
         ActionPositionFacet actionPositionFacet = ActionPositionFacetOnActionFromLayoutProperties.create(properties, holder);
-        if(actionPositionFacet == null) {
+        if(actionPositionFacet == null && ! holder.containsDoOpFacet(ActionPositionFacet.class)) {
             actionPositionFacet = new ActionPositionFacetFallback(holder);
         }
         FacetUtil.addFacet(actionPositionFacet);