You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2016/05/04 00:02:11 UTC

[GitHub] spark pull request: [SPARK-14603] [SQL] [WIP] Verification of Meta...

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12385#discussion_r61976218
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala ---
    @@ -107,18 +105,16 @@ class InMemoryCatalog extends ExternalCatalog {
           catalog.remove(db)
         } else {
           if (!ignoreIfNotExists) {
    -        throw new AnalysisException(s"Database '$db' does not exist")
    +        throw new NoSuchDatabaseException(db)
           }
         }
       }
     
       override def alterDatabase(dbDefinition: CatalogDatabase): Unit = synchronized {
    -    requireDbExists(dbDefinition.name)
         catalog(dbDefinition.name).db = dbDefinition
       }
     
       override def getDatabase(db: String): CatalogDatabase = synchronized {
    -    requireDbExists(db)
    --- End diff --
    
    why remove these?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org