You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by "Uri Goldstein (JIRA)" <ji...@apache.org> on 2010/02/03 22:55:27 UTC

[jira] Created: (LOG4NET-246) Make it possible to choose whether or not to watch configuration files specified using the "log4net.Config" appsetting key

Make it possible to choose whether or not to watch configuration files specified using the "log4net.Config" appsetting key 
---------------------------------------------------------------------------------------------------------------------------

                 Key: LOG4NET-246
                 URL: https://issues.apache.org/jira/browse/LOG4NET-246
             Project: Log4net
          Issue Type: Improvement
          Components: Core
    Affects Versions: 1.2.10
            Reporter: Uri Goldstein
            Priority: Minor


Currently (v1.2.10) it is possible to specify a configuration file for log4net by adding a key like this in the host application's configuration <appSettings> section:
<add key="log4net.Config" value="Log.config" />

This defaults to invoking XmlConfigurator.Configure() on the file specified (log4net/Core/DefaultRepositorySelector.cs,  line 725). This means the file is not watched for changes during program run time.

It would be nice if there was some way similar to the above <appSettings> key to specify whether log4net should watch the file or not.

I might propose that a new key is introduced in this fashion:
<add key="log4net.Config.Watch" value="true" />

This key would denote a bool value defaulting to false. The value would only be taken into consideration if the "log4net.Config" key is specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LOG4NET-246) Make it possible to choose whether or not to watch configuration files specified using the "log4net.Config" appsetting key

Posted by "Uri Goldstein (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LOG4NET-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uri Goldstein updated LOG4NET-246:
----------------------------------

    Attachment: DefaultRepositorySelector-LOG4NET-246-PatchA.patch

This is a patch to the v1.2.10 Core\DefaultRepositoriSelector.cs file. In it I've implemented watch functionality based on a new app setting called "log4net.Config.Web" as described in the issue itself.

> Make it possible to choose whether or not to watch configuration files specified using the "log4net.Config" appsetting key 
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-246
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-246
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.10
>            Reporter: Uri Goldstein
>            Priority: Minor
>         Attachments: DefaultRepositorySelector-LOG4NET-246-PatchA.patch
>
>
> Currently (v1.2.10) it is possible to specify a configuration file for log4net by adding a key like this in the host application's configuration <appSettings> section:
> <add key="log4net.Config" value="Log.config" />
> This defaults to invoking XmlConfigurator.Configure() on the file specified (log4net/Core/DefaultRepositorySelector.cs,  line 725). This means the file is not watched for changes during program run time.
> It would be nice if there was some way similar to the above <appSettings> key to specify whether log4net should watch the file or not.
> I might propose that a new key is introduced in this fashion:
> <add key="log4net.Config.Watch" value="true" />
> This key would denote a bool value defaulting to false. The value would only be taken into consideration if the "log4net.Config" key is specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LOG4NET-246) Make it possible to choose whether or not to watch configuration files specified using the "log4net.Config" appsetting key

Posted by "Uri Goldstein (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LOG4NET-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889820#action_12889820 ] 

Uri Goldstein commented on LOG4NET-246:
---------------------------------------

What do I need to do to have this patch reviewed by log4net contributers and integrated?

> Make it possible to choose whether or not to watch configuration files specified using the "log4net.Config" appsetting key 
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-246
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-246
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.10
>            Reporter: Uri Goldstein
>            Priority: Minor
>         Attachments: DefaultRepositorySelector-LOG4NET-246-PatchA.patch
>
>
> Currently (v1.2.10) it is possible to specify a configuration file for log4net by adding a key like this in the host application's configuration <appSettings> section:
> <add key="log4net.Config" value="Log.config" />
> This defaults to invoking XmlConfigurator.Configure() on the file specified (log4net/Core/DefaultRepositorySelector.cs,  line 725). This means the file is not watched for changes during program run time.
> It would be nice if there was some way similar to the above <appSettings> key to specify whether log4net should watch the file or not.
> I might propose that a new key is introduced in this fashion:
> <add key="log4net.Config.Watch" value="true" />
> This key would denote a bool value defaulting to false. The value would only be taken into consideration if the "log4net.Config" key is specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.