You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/10 08:39:46 UTC
[GitHub] [dubbo-go-samples] xiaoliu10 opened a new pull request #22: modify consul demo to support makefile
xiaoliu10 opened a new pull request #22:
URL: https://github.com/apache/dubbo-go-samples/pull/22
1. support makefile
2. remove dead code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] xiaoliu10 commented on a change in pull request #22: modify consul demo to support makefile
Posted by GitBox <gi...@apache.org>.
xiaoliu10 commented on a change in pull request #22:
URL: https://github.com/apache/dubbo-go-samples/pull/22#discussion_r541831078
##########
File path: registry/servicediscovery/consul/go-client/pkg/user.go
##########
@@ -15,25 +15,13 @@
* limitations under the License.
*/
-package main
+package pkg
Review comment:
all samples use pkg , so do i
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #22: modify consul demo to support makefile
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #22:
URL: https://github.com/apache/dubbo-go-samples/pull/22#discussion_r541856017
##########
File path: registry/servicediscovery/consul/go-client/cmd/client.go
##########
@@ -27,6 +27,11 @@ import (
)
import (
+ "github.com/apache/dubbo-go-samples/registry/servicediscovery/consul/go-client/pkg"
Review comment:
the position of the package itself should be the third import block.
##########
File path: registry/servicediscovery/consul/go-server/tests/integration/main_test.go
##########
@@ -0,0 +1,75 @@
+// +build integration
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package integration
+
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
+
+ _ "github.com/apache/dubbo-go/cluster/cluster_impl"
+ _ "github.com/apache/dubbo-go/cluster/loadbalance"
+ _ "github.com/apache/dubbo-go/common/proxy/proxy_factory"
+ "github.com/apache/dubbo-go/config"
+ _ "github.com/apache/dubbo-go/filter/filter_impl"
+ _ "github.com/apache/dubbo-go/metadata/mapping/memory"
+ _ "github.com/apache/dubbo-go/metadata/report/consul"
+ _ "github.com/apache/dubbo-go/metadata/service/remote"
+ _ "github.com/apache/dubbo-go/protocol/dubbo"
+ _ "github.com/apache/dubbo-go/protocol/jsonrpc"
+ _ "github.com/apache/dubbo-go/registry/consul"
+ _ "github.com/apache/dubbo-go/registry/protocol"
+ _ "github.com/apache/dubbo-go/registry/servicediscovery"
+)
+
+import (
Review comment:
move it to 1st import block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] zouyx merged pull request #22: modify consul demo to support makefile
Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #22:
URL: https://github.com/apache/dubbo-go-samples/pull/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #22: modify consul demo to support makefile
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #22:
URL: https://github.com/apache/dubbo-go-samples/pull/22#discussion_r541815325
##########
File path: registry/servicediscovery/consul/go-client/pkg/user.go
##########
@@ -15,25 +15,13 @@
* limitations under the License.
*/
-package main
+package pkg
Review comment:
maybe u can change the dir name. 'pkg' is not so good.
##########
File path: registry/servicediscovery/consul/go-client/cmd/client.go
##########
@@ -20,6 +20,8 @@ package main
import (
"context"
"fmt"
+ hessian "github.com/apache/dubbo-go-hessian2"
+ "github.com/apache/dubbo-go-samples/registry/servicediscovery/consul/go-client/pkg"
Review comment:
the same as above.
##########
File path: registry/servicediscovery/consul/go-client/cmd/client.go
##########
@@ -20,6 +20,8 @@ package main
import (
"context"
"fmt"
+ hessian "github.com/apache/dubbo-go-hessian2"
Review comment:
hey, guy, move it, pls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org