[GitHub] [pulsar] Jason918 commented on a diff in pull request #15147: [cleanup] Remove unused parameters in method

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #15147:
URL: https://github.com/apache/pulsar/pull/15147#discussion_r851735752


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/BrokerFilter.java:
##########
@@ -36,15 +35,13 @@ public interface BrokerFilter {
      * @param brokers
      *            The currently available brokers that have not already been filtered. This set may be modified by
      *            filter.
-     * @param bundleToAssign
-     *            The data for the bundle to assign.
      * @param loadData
      *            The load data from the leader broker.
      * @param conf
      *            The service configuration.
      * @throws BrokerFilterException
      *            There was an error in the pipeline and the brokers should be reset to their original value
      */
-    void filter(Set<String> brokers, BundleData bundleToAssign, LoadData loadData, ServiceConfiguration conf)
+    void filter(Set<String> brokers, LoadData loadData, ServiceConfiguration conf)

Review Comment:
   It's better not to change this. Some developer may use custom filter class. Let's keep the expansibility。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org