[jira] [Commented] (BEAM-2080) Add custom maven enforcer rules to catch banned classes and dependencies

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983824#comment-15983824 ] 

ASF GitHub Bot commented on BEAM-2080:
--------------------------------------

GitHub user vikkyrk opened a pull request:

    https://github.com/apache/beam/pull/2688

    [BEAM-2080]: Add a custom enforcer rule to check for banned classes.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    - Add a custom rule to catch banned classes which can be specified using full path like `org/apache/beam/Foo.class` or using wildcards like `org/apache/maven/**` 
    - Disable enforcer plugin in parent pom to avoid circular dependency issues with the custom rule
    - Move enforcer executions to `pluginManagement` and explicitly include them in `sdks`, `examples` and `runners`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam mvn_enforcer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2688
    
----
commit 48034b365ab89b4e4f37c64345269cb534a87212
Author: Vikas Kedigehalli <vi...@google.com>
Date:   2017-04-21T22:10:21Z

    Add a custom rule to check for banned classes.

----


> Add custom maven enforcer rules to catch banned classes and dependencies
> ------------------------------------------------------------------------
>
>                 Key: BEAM-2080
>                 URL: https://issues.apache.org/jira/browse/BEAM-2080
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>    Affects Versions: Not applicable
>            Reporter: Vikas Kedigehalli
>            Assignee: Vikas Kedigehalli
>            Priority: Minor
>
> The maven enforcer plugin standard rules aren't sufficient to catch certain issues like:
> * An artifact built as an uber/bundled jar (usually with shade plugin) including banned classes. 
> * An artifact pom that depends on banned dependencies. (bannedDependencies rule provided by enforcer plugin doesn't work always because it doesn't look at the dependency-reduced-pom generated by shade plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)