You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/29 03:14:35 UTC
[GitHub] [arrow-datafusion] happysalada opened a new pull request #2112: cli: add cargo.lock
happysalada opened a new pull request #2112:
URL: https://github.com/apache/arrow-datafusion/pull/2112
# Which issue does this PR close?
Add a cargo.lock to enable packaging for different os.
Since cargo will not tolerate a lock that is not at the root of the workspace, I had to add the lock there.
I've added some exclude statements for it not to be included for all the other libraries.
Closes #.
# Are there any user-facing changes?
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2112: cli: add cargo.lock
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #2112:
URL: https://github.com/apache/arrow-datafusion/pull/2112#issuecomment-1086832519
Looks like the integration test also wants to use datafusion-cli and the build script needs to be updated
https://github.com/apache/arrow-datafusion/runs/5799193929?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #2112: cli: add cargo.lock
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #2112:
URL: https://github.com/apache/arrow-datafusion/pull/2112#issuecomment-1081410742
@happysalada I think you need to put the lock file inside the datafusion-cli directory instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #2112: cli: add cargo.lock
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #2112:
URL: https://github.com/apache/arrow-datafusion/pull/2112#issuecomment-1086545999
LGTM, thanks @happysalada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #2112: cli: add cargo.lock
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #2112:
URL: https://github.com/apache/arrow-datafusion/pull/2112#issuecomment-1081477416
Ha, I saw your other comment now, @happysalada you need to exclude datafusion-cli from the root workspace by removing it from https://github.com/apache/arrow-datafusion/blob/b7d3bb1e3f2a884fc0775dc9dc869ae77b226269/Cargo.toml#L26. Then add it to an exclude list, something like this: https://github.com/delta-io/delta-rs/blob/346f51a277c23be09eca373cd6d775b745d59c05/Cargo.toml#L10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] happysalada commented on pull request #2112: cli: add cargo.lock
Posted by GitBox <gi...@apache.org>.
happysalada commented on pull request #2112:
URL: https://github.com/apache/arrow-datafusion/pull/2112#issuecomment-1086511467
@houqp let me know what you think when you have a moment. (no worries if you are busy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] happysalada commented on pull request #2112: cli: add cargo.lock
Posted by GitBox <gi...@apache.org>.
happysalada commented on pull request #2112:
URL: https://github.com/apache/arrow-datafusion/pull/2112#issuecomment-1086857827
it looks like 2 more files need to be updated.
I've updated the python integration tests file.
however the workflow file also needs to be modified here https://github.com/apache/arrow-datafusion/commit/30341de85a93c875a4542fc48c960187a4a219e2#diff-73e17259d77e5fbef83b2bdbbe4dc40a912f807472287f7f45b77e0cbf78792dL213
I don't think I can do that though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] happysalada commented on pull request #2112: cli: add cargo.lock
Posted by GitBox <gi...@apache.org>.
happysalada commented on pull request #2112:
URL: https://github.com/apache/arrow-datafusion/pull/2112#issuecomment-1081834078
I had another go at it doing what you suggested, let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org