[GitHub] bigtop pull request #406: Remove the advertise.host.name override.

[cmars <gi...@git.apache.org>]

GitHub user cmars opened a pull request:

    https://github.com/apache/bigtop/pull/406

    Remove the advertise.host.name override.

    The short host name used in `set_advertise` to rewrite `advertised.host.name` is not guaranteed to be resolvable by other kafka members of a cluster, or kafka clients. The comment on this removed code
    seems to suggest that an admin should configure this short name to
    resolve on clients outside of juju. The problem is, these short names also must resolve on all kafka
    cluster nodes, and then each client will need to resolve the short name of
    each cluster member. Otherwise, the cluster basically unusable -- clients fail to find a leader.
    
    While being able to configure `advertised.host.name` is potentially
    useful, IMO there should be a config option that sets this value in the
    puppet module template. The charm should not be modifying `server.properties` after puppet has
    generated it.
    
    By removing `set_advertise`, the charm becomes more useful -- if
    the config option `network_interface` is set, host.name is defined and all the kafka nodes
    in a cluster can resolve the implicit default `advertised.host.name`, which is
    the IP address of the configured interface. Clients can connect to this
    IP address.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cmars/bigtop remove_set_advertise

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #406
    
----

----


---