You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Swapnil Ghike <sg...@linkedin.com> on 2013/09/16 19:03:20 UTC

Review Request 14149: test summary

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14149/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1003
    https://issues.apache.org/jira/browse/KAFKA-1003


Repository: kafka


Description
-------

test description


Diffs
-----

  bin/kafka-server-stop.sh 516c6adeda44642b0000a20ad35468569e6b7db5 
  core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 8d287f498b0061d6fa38268ec00de090f7cca516 
  core/src/main/scala/kafka/cluster/Broker.scala 435c47348eb5889cd1f416ebbf874ab33a632741 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b28631253c46ed002fcf3674b5a14c01a3026740 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 1c283280873eef597018f2f0a5ddfec942356c18 
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 17977e7ebe9646ddae4e5386f674855f23d5597f 
  core/src/main/scala/kafka/controller/KafkaController.scala 800f900347f8681f395edb5d325ee1da39e98539 
  core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 9f752f46762946ea55bdec050bae79a4e8d0ad3b 
  core/src/main/scala/kafka/network/RequestChannel.scala 1437496c7284d0c9c33b741cdb954572047b5ae2 
  core/src/main/scala/kafka/network/SocketServer.scala d5bd14349c7a9b10313afee11ff5530b6a80827d 
  core/src/main/scala/kafka/producer/ConsoleProducer.scala 5539bcef4c1f537404aa1ef3cd57f736af62f55d 
  core/src/main/scala/kafka/producer/Producer.scala bb16a297b950d826a974b915013841c2e9b77110 
  core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala f71a242968a26063b3ad81e405dfced31c611854 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 7663face23ef58908fcbfd80c8abc303460964fe 
  core/src/main/scala/kafka/server/KafkaApis.scala 208e3ef59ab999fb0bbeef08f15adea09ee6c57c 
  core/src/main/scala/kafka/server/KafkaRequestHandler.scala fed0b86916b4a93eeaafd2bd82f0bf928cebd623 
  core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala d785db9e4ce31ded4b19e4194641b130c759633b 
  core/src/main/scala/kafka/tools/ImportZkOffsets.scala 63519e12ed5044dca0f53b0bc1234ba8fa861cd7 
  core/src/main/scala/kafka/tools/MirrorMaker.scala c747bfbd0c2d3efc9eb6da5dcd52b855e418898d 
  core/src/main/scala/kafka/utils/ZkUtils.scala 9772af8e485868d997f3ae4c9cfa78215342c181 
  core/src/test/scala/unit/kafka/producer/ProducerTest.scala b511d909017be5e2b667fa580a4aaab4ce46b429 
  core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala b5ee31d517853dfb9c2880ddf71eca480f9fcbf6 
  sbt.bat 9321ada9316ac420ee3639488e639ec452b64f09 

Diff: https://reviews.apache.org/r/14149/diff/


Testing
-------


Thanks,

Swapnil Ghike


Re: Review Request 14149: test summary

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14149/#review26143
-----------------------------------------------------------


I did not see changes on AbstractFetcherManager/ConsumerFetcherManager?


core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
<https://reviews.apache.org/r/14149/#comment51049>

    Should this file-change be part of this JIRA?



core/src/main/scala/kafka/cluster/Broker.scala
<https://reviews.apache.org/r/14149/#comment51050>

    Ditto, I think maybe a rebase is needed.


- Guozhang Wang


On Sept. 16, 2013, 5:03 p.m., Swapnil Ghike wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14149/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2013, 5:03 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1003
>     https://issues.apache.org/jira/browse/KAFKA-1003
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> test description
> 
> 
> Diffs
> -----
> 
>   bin/kafka-server-stop.sh 516c6adeda44642b0000a20ad35468569e6b7db5 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 8d287f498b0061d6fa38268ec00de090f7cca516 
>   core/src/main/scala/kafka/cluster/Broker.scala 435c47348eb5889cd1f416ebbf874ab33a632741 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b28631253c46ed002fcf3674b5a14c01a3026740 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 1c283280873eef597018f2f0a5ddfec942356c18 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 17977e7ebe9646ddae4e5386f674855f23d5597f 
>   core/src/main/scala/kafka/controller/KafkaController.scala 800f900347f8681f395edb5d325ee1da39e98539 
>   core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 9f752f46762946ea55bdec050bae79a4e8d0ad3b 
>   core/src/main/scala/kafka/network/RequestChannel.scala 1437496c7284d0c9c33b741cdb954572047b5ae2 
>   core/src/main/scala/kafka/network/SocketServer.scala d5bd14349c7a9b10313afee11ff5530b6a80827d 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala 5539bcef4c1f537404aa1ef3cd57f736af62f55d 
>   core/src/main/scala/kafka/producer/Producer.scala bb16a297b950d826a974b915013841c2e9b77110 
>   core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala f71a242968a26063b3ad81e405dfced31c611854 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 7663face23ef58908fcbfd80c8abc303460964fe 
>   core/src/main/scala/kafka/server/KafkaApis.scala 208e3ef59ab999fb0bbeef08f15adea09ee6c57c 
>   core/src/main/scala/kafka/server/KafkaRequestHandler.scala fed0b86916b4a93eeaafd2bd82f0bf928cebd623 
>   core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala d785db9e4ce31ded4b19e4194641b130c759633b 
>   core/src/main/scala/kafka/tools/ImportZkOffsets.scala 63519e12ed5044dca0f53b0bc1234ba8fa861cd7 
>   core/src/main/scala/kafka/tools/MirrorMaker.scala c747bfbd0c2d3efc9eb6da5dcd52b855e418898d 
>   core/src/main/scala/kafka/utils/ZkUtils.scala 9772af8e485868d997f3ae4c9cfa78215342c181 
>   core/src/test/scala/unit/kafka/producer/ProducerTest.scala b511d909017be5e2b667fa580a4aaab4ce46b429 
>   core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala b5ee31d517853dfb9c2880ddf71eca480f9fcbf6 
>   sbt.bat 9321ada9316ac420ee3639488e639ec452b64f09 
> 
> Diff: https://reviews.apache.org/r/14149/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Swapnil Ghike
> 
>