[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4401: NO-JIRA Cleanup MBeanServer usage in the testsuite as it is leaking

["clebertsuconic (via GitHub)" <gi...@apache.org>]

clebertsuconic commented on code in PR #4401:
URL: https://github.com/apache/activemq-artemis/pull/4401#discussion_r1139117731


##########
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java:
##########
@@ -176,6 +178,12 @@
  */
 public abstract class ActiveMQTestBase extends Assert {
 
+   public MBeanServer getMBeanServer() {
+      MBeanServer mBeanServer = MBeanServerFactory.createMBeanServer();
+      runAfter(() -> MBeanServerFactory.releaseMBeanServer(mBeanServer));
+      return mBeanServer;
+   }

Review Comment:
   It's getting you one from somewhere, right? :) 
   
   
   but I can rename it .. sure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org