You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2023/02/11 00:29:33 UTC
[GitHub] [arrow-datafusion] comphead opened a new pull request, #5246: [SQLLogicTest] Remove schema check
comphead opened a new pull request, #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5231 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Remove IMHO unnecessary schema check for SLT, this check prevents to run test cases having mixed nulls and non null values
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
Its tested, since all SLT tests running fine
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] melgenek commented on pull request #5246: [SQLLogicTest] Remove schema check
Posted by "melgenek (via GitHub)" <gi...@apache.org>.
melgenek commented on PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1426695705
I, unfortunately, cannot tell if this check is always needed. It was added in https://github.com/apache/arrow-datafusion/pull/4578/files#diff-4d4a58673140be1acf7a04b9aa71a29f106ebb75a256553e2a9ff13d9a3856f4. @alamb Could you please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on pull request #5246: [SQLLogicTest] Remove schema check
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1426531092
@melgenek https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/sqllogictests/src/engines/datafusion/normalize.rs#L44
Please double check if schema comparison is needed? Is there any real scenario that Dataframe has schema incosistency between first batches and other batches?
I have noticed the only diff can be for nullable or metadata in optimizer, but this ignored like [equivalent_names_and_types](https://github.com/apache/arrow-datafusion/blob/master/datafusion/common/src/dfschema.rs#L345).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5246: [SQLLogicTest] Make schema validation ignore nullable and metadata attributes
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] melgenek commented on pull request #5246: [SQLLogicTest] Remove schema check
Posted by "melgenek (via GitHub)" <gi...@apache.org>.
melgenek commented on PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1426761161
> It might be safer to change the check to verify the fields name and types (rather than schema == schema).
I re-opened this page to say the same thing 🙂 Totally agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5246: [SQLLogicTest] Make schema validation ignore nullable and metadata attributes
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1427004548
Benchmark runs are scheduled for baseline = f75d25fec2c1a5581eeb8ce73a890e5792df02c7 and contender = 0c0ed1c456c0dce8d3479bbd666b744ba5454016. 0c0ed1c456c0dce8d3479bbd666b744ba5454016 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6b7d68c6f8644b58bfa05641cd69ae8b...35d021e44aab4e55a8f81fd1c881451f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/428099e9b3e24a338e8c4652f707ff47...f90e8b8444434ab385dddd73b955f76f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0cf8b0cdcbe04f6a8dfa3d05d7969b52...34f8d7fd208241a5a6b29e6b1fd36968/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f58ea5497b5c4ab686a14570042cf64b...0473c01ad21b4907935ec15709aa8a2b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on pull request #5246: [SQLLogicTest] Remove schema check
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1426829245
> > I, unfortunately, cannot tell if this check is always needed. It was added in https://github.com/apache/arrow-datafusion/pull/4578/files#diff-4d4a58673140be1acf7a04b9aa71a29f106ebb75a256553e2a9ff13d9a3856f4. @alamb Could you please take a look.
>
> We have seen this in the past where schemas differ only in nullability (hence `equivalent_names_and_types`)
>
> It might be safer to change the check to verify the fields name and types (rather than `schema == schema`). What do you think @comphead and @melgenek ?
I'm still thinking the check is redundant, as batches within one query execution shouldn't have difference in types and fields. But to be safe I'll add the type/fields check today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5246: [SQLLogicTest] Remove schema check
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1426760371
> I, unfortunately, cannot tell if this check is always needed. It was added in https://github.com/apache/arrow-datafusion/pull/4578/files#diff-4d4a58673140be1acf7a04b9aa71a29f106ebb75a256553e2a9ff13d9a3856f4. @alamb Could you please take a look.
We have seen this in the past where schemas differ only in nullability (hence `equivalent_names_and_types`)
It might be safer to change the check to verify the fields name and types (rather than `schema == schema`). What do you think @comphead and @melgenek ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5246: [SQLLogicTest] Remove schema check
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5246:
URL: https://github.com/apache/arrow-datafusion/pull/5246#issuecomment-1426834017
> I'm still thinking the check is redundant, as batches within one query execution shouldn't have difference in types and fields. But to be safe I'll add the type/fields check today
right -- they definitely *SHOULD NOT* be different between batches, so I think it is good to be verifying them as part of the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org