You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Shazron Abdullah (Created) (JIRA)" <ji...@apache.org> on 2012/04/10 19:49:13 UTC

[jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0

FileTransfer js callbacks not working in 1.6.0
----------------------------------------------

                 Key: CB-475
                 URL: https://issues.apache.org/jira/browse/CB-475
             Project: Apache Callback
          Issue Type: Bug
          Components: iOS
            Reporter: Shazron Abdullah
            Assignee: Shazron Abdullah
            Priority: Blocker


The callbacks are still using the old cast style. Remove.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0

Posted by Marcus Wu <wu...@bibliolabs.com>.
Sure, that works. I've used git in projects before, but in a small team and not on github so pull requests are new to me. I'll keep that in mind in the future.

On Apr 10, 2012, at 3:22 PM, Shazron wrote:

> That pull request has the original commit in it - your updates should
> be in a separate pull req. I've just integrated your changes manually,
> if that's ok (copy paste the relevant sections)
> 
> On Tue, Apr 10, 2012 at 12:14 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
>> Alright, that works. I would like to point out that for downloads right now the success callback is always being run. Take a look at this if you have a moment: https://github.com/marcuswu/incubator-cordova-ios/compare/CB-475
>> 
>> The issue was that there were a couple of error conditions I handled properly in connectionDidFinishLoading while creating the result, but at the bottom of the routine I always wrote the javascript with toSuccessCallbackString. The changes referenced above make it run toErrorCallbackString when it is proper to do so.
>> 
>> On Apr 10, 2012, at 3:05 PM, Shazron wrote:
>> 
>>> Thanks Marcus - I've already fixed it, I'm just working out a crash
>>> bug in uploads which is inconsistent sometimes it happens sometime it
>>> doesnt (Xcode is being wonky)
>>> 
>>> On Tue, Apr 10, 2012 at 12:03 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
>>>> Shazron,
>>>> 
>>>> I have some code in a branch that removes the cast references from FileTransfer. It works for the download, but I don't have code handy to test uploads. Shall I create a pull request?
>>>> 
>>>> Thanks,
>>>> Marcus
>>>> 
>>>> On Apr 10, 2012, at 1:49 PM, Shazron Abdullah (Created) (JIRA) wrote:
>>>> 
>>>>> FileTransfer js callbacks not working in 1.6.0
>>>>> ----------------------------------------------
>>>>> 
>>>>>                 Key: CB-475
>>>>>                 URL: https://issues.apache.org/jira/browse/CB-475
>>>>>             Project: Apache Callback
>>>>>          Issue Type: Bug
>>>>>          Components: iOS
>>>>>            Reporter: Shazron Abdullah
>>>>>            Assignee: Shazron Abdullah
>>>>>            Priority: Blocker
>>>>> 
>>>>> 
>>>>> The callbacks are still using the old cast style. Remove.
>>>>> 
>>>>> --
>>>>> This message is automatically generated by JIRA.
>>>>> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>>> 
>>>>> 
>>>> 
>> 


Re: [jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0

Posted by Shazron <sh...@gmail.com>.
No worries - fixed

On Tue, Apr 10, 2012 at 1:33 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
> Sorry for being a pain, but I think after line 268 there should be an errored = YES since that conditional is for if writing the download to file failed.
>
> On Apr 10, 2012, at 3:22 PM, Shazron wrote:
>
>> That pull request has the original commit in it - your updates should
>> be in a separate pull req. I've just integrated your changes manually,
>> if that's ok (copy paste the relevant sections)
>>
>> On Tue, Apr 10, 2012 at 12:14 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
>>> Alright, that works. I would like to point out that for downloads right now the success callback is always being run. Take a look at this if you have a moment: https://github.com/marcuswu/incubator-cordova-ios/compare/CB-475
>>>
>>> The issue was that there were a couple of error conditions I handled properly in connectionDidFinishLoading while creating the result, but at the bottom of the routine I always wrote the javascript with toSuccessCallbackString. The changes referenced above make it run toErrorCallbackString when it is proper to do so.
>>>
>>> On Apr 10, 2012, at 3:05 PM, Shazron wrote:
>>>
>>>> Thanks Marcus - I've already fixed it, I'm just working out a crash
>>>> bug in uploads which is inconsistent sometimes it happens sometime it
>>>> doesnt (Xcode is being wonky)
>>>>
>>>> On Tue, Apr 10, 2012 at 12:03 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
>>>>> Shazron,
>>>>>
>>>>> I have some code in a branch that removes the cast references from FileTransfer. It works for the download, but I don't have code handy to test uploads. Shall I create a pull request?
>>>>>
>>>>> Thanks,
>>>>> Marcus
>>>>>
>>>>> On Apr 10, 2012, at 1:49 PM, Shazron Abdullah (Created) (JIRA) wrote:
>>>>>
>>>>>> FileTransfer js callbacks not working in 1.6.0
>>>>>> ----------------------------------------------
>>>>>>
>>>>>>                 Key: CB-475
>>>>>>                 URL: https://issues.apache.org/jira/browse/CB-475
>>>>>>             Project: Apache Callback
>>>>>>          Issue Type: Bug
>>>>>>          Components: iOS
>>>>>>            Reporter: Shazron Abdullah
>>>>>>            Assignee: Shazron Abdullah
>>>>>>            Priority: Blocker
>>>>>>
>>>>>>
>>>>>> The callbacks are still using the old cast style. Remove.
>>>>>>
>>>>>> --
>>>>>> This message is automatically generated by JIRA.
>>>>>> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>>>>
>>>>>>
>>>>>
>>>
>

Re: [jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0

Posted by Marcus Wu <wu...@bibliolabs.com>.
Sorry for being a pain, but I think after line 268 there should be an errored = YES since that conditional is for if writing the download to file failed.

On Apr 10, 2012, at 3:22 PM, Shazron wrote:

> That pull request has the original commit in it - your updates should
> be in a separate pull req. I've just integrated your changes manually,
> if that's ok (copy paste the relevant sections)
> 
> On Tue, Apr 10, 2012 at 12:14 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
>> Alright, that works. I would like to point out that for downloads right now the success callback is always being run. Take a look at this if you have a moment: https://github.com/marcuswu/incubator-cordova-ios/compare/CB-475
>> 
>> The issue was that there were a couple of error conditions I handled properly in connectionDidFinishLoading while creating the result, but at the bottom of the routine I always wrote the javascript with toSuccessCallbackString. The changes referenced above make it run toErrorCallbackString when it is proper to do so.
>> 
>> On Apr 10, 2012, at 3:05 PM, Shazron wrote:
>> 
>>> Thanks Marcus - I've already fixed it, I'm just working out a crash
>>> bug in uploads which is inconsistent sometimes it happens sometime it
>>> doesnt (Xcode is being wonky)
>>> 
>>> On Tue, Apr 10, 2012 at 12:03 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
>>>> Shazron,
>>>> 
>>>> I have some code in a branch that removes the cast references from FileTransfer. It works for the download, but I don't have code handy to test uploads. Shall I create a pull request?
>>>> 
>>>> Thanks,
>>>> Marcus
>>>> 
>>>> On Apr 10, 2012, at 1:49 PM, Shazron Abdullah (Created) (JIRA) wrote:
>>>> 
>>>>> FileTransfer js callbacks not working in 1.6.0
>>>>> ----------------------------------------------
>>>>> 
>>>>>                 Key: CB-475
>>>>>                 URL: https://issues.apache.org/jira/browse/CB-475
>>>>>             Project: Apache Callback
>>>>>          Issue Type: Bug
>>>>>          Components: iOS
>>>>>            Reporter: Shazron Abdullah
>>>>>            Assignee: Shazron Abdullah
>>>>>            Priority: Blocker
>>>>> 
>>>>> 
>>>>> The callbacks are still using the old cast style. Remove.
>>>>> 
>>>>> --
>>>>> This message is automatically generated by JIRA.
>>>>> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>>> 
>>>>> 
>>>> 
>> 


Re: [jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0

Posted by Shazron <sh...@gmail.com>.
That pull request has the original commit in it - your updates should
be in a separate pull req. I've just integrated your changes manually,
if that's ok (copy paste the relevant sections)

On Tue, Apr 10, 2012 at 12:14 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
> Alright, that works. I would like to point out that for downloads right now the success callback is always being run. Take a look at this if you have a moment: https://github.com/marcuswu/incubator-cordova-ios/compare/CB-475
>
> The issue was that there were a couple of error conditions I handled properly in connectionDidFinishLoading while creating the result, but at the bottom of the routine I always wrote the javascript with toSuccessCallbackString. The changes referenced above make it run toErrorCallbackString when it is proper to do so.
>
> On Apr 10, 2012, at 3:05 PM, Shazron wrote:
>
>> Thanks Marcus - I've already fixed it, I'm just working out a crash
>> bug in uploads which is inconsistent sometimes it happens sometime it
>> doesnt (Xcode is being wonky)
>>
>> On Tue, Apr 10, 2012 at 12:03 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
>>> Shazron,
>>>
>>> I have some code in a branch that removes the cast references from FileTransfer. It works for the download, but I don't have code handy to test uploads. Shall I create a pull request?
>>>
>>> Thanks,
>>> Marcus
>>>
>>> On Apr 10, 2012, at 1:49 PM, Shazron Abdullah (Created) (JIRA) wrote:
>>>
>>>> FileTransfer js callbacks not working in 1.6.0
>>>> ----------------------------------------------
>>>>
>>>>                 Key: CB-475
>>>>                 URL: https://issues.apache.org/jira/browse/CB-475
>>>>             Project: Apache Callback
>>>>          Issue Type: Bug
>>>>          Components: iOS
>>>>            Reporter: Shazron Abdullah
>>>>            Assignee: Shazron Abdullah
>>>>            Priority: Blocker
>>>>
>>>>
>>>> The callbacks are still using the old cast style. Remove.
>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>>
>>>>
>>>
>

Re: [jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0

Posted by Marcus Wu <wu...@bibliolabs.com>.
Alright, that works. I would like to point out that for downloads right now the success callback is always being run. Take a look at this if you have a moment: https://github.com/marcuswu/incubator-cordova-ios/compare/CB-475

The issue was that there were a couple of error conditions I handled properly in connectionDidFinishLoading while creating the result, but at the bottom of the routine I always wrote the javascript with toSuccessCallbackString. The changes referenced above make it run toErrorCallbackString when it is proper to do so.

On Apr 10, 2012, at 3:05 PM, Shazron wrote:

> Thanks Marcus - I've already fixed it, I'm just working out a crash
> bug in uploads which is inconsistent sometimes it happens sometime it
> doesnt (Xcode is being wonky)
> 
> On Tue, Apr 10, 2012 at 12:03 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
>> Shazron,
>> 
>> I have some code in a branch that removes the cast references from FileTransfer. It works for the download, but I don't have code handy to test uploads. Shall I create a pull request?
>> 
>> Thanks,
>> Marcus
>> 
>> On Apr 10, 2012, at 1:49 PM, Shazron Abdullah (Created) (JIRA) wrote:
>> 
>>> FileTransfer js callbacks not working in 1.6.0
>>> ----------------------------------------------
>>> 
>>>                 Key: CB-475
>>>                 URL: https://issues.apache.org/jira/browse/CB-475
>>>             Project: Apache Callback
>>>          Issue Type: Bug
>>>          Components: iOS
>>>            Reporter: Shazron Abdullah
>>>            Assignee: Shazron Abdullah
>>>            Priority: Blocker
>>> 
>>> 
>>> The callbacks are still using the old cast style. Remove.
>>> 
>>> --
>>> This message is automatically generated by JIRA.
>>> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>> 
>>> 
>> 


Re: [jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0

Posted by Shazron <sh...@gmail.com>.
Thanks Marcus - I've already fixed it, I'm just working out a crash
bug in uploads which is inconsistent sometimes it happens sometime it
doesnt (Xcode is being wonky)

On Tue, Apr 10, 2012 at 12:03 PM, Marcus Wu <wu...@bibliolabs.com> wrote:
> Shazron,
>
> I have some code in a branch that removes the cast references from FileTransfer. It works for the download, but I don't have code handy to test uploads. Shall I create a pull request?
>
> Thanks,
> Marcus
>
> On Apr 10, 2012, at 1:49 PM, Shazron Abdullah (Created) (JIRA) wrote:
>
>> FileTransfer js callbacks not working in 1.6.0
>> ----------------------------------------------
>>
>>                 Key: CB-475
>>                 URL: https://issues.apache.org/jira/browse/CB-475
>>             Project: Apache Callback
>>          Issue Type: Bug
>>          Components: iOS
>>            Reporter: Shazron Abdullah
>>            Assignee: Shazron Abdullah
>>            Priority: Blocker
>>
>>
>> The callbacks are still using the old cast style. Remove.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>

Re: [jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0

Posted by Marcus Wu <wu...@bibliolabs.com>.
Shazron,

I have some code in a branch that removes the cast references from FileTransfer. It works for the download, but I don't have code handy to test uploads. Shall I create a pull request?

Thanks,
Marcus

On Apr 10, 2012, at 1:49 PM, Shazron Abdullah (Created) (JIRA) wrote:

> FileTransfer js callbacks not working in 1.6.0
> ----------------------------------------------
> 
>                 Key: CB-475
>                 URL: https://issues.apache.org/jira/browse/CB-475
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>            Priority: Blocker
> 
> 
> The callbacks are still using the old cast style. Remove.
> 
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
> 
> 


[jira] [Resolved] (CB-475) FileTransfer js callbacks not working in 1.6.0

Posted by "Shazron Abdullah (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shazron Abdullah resolved CB-475.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6.0

Fix commit: http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=0bb76edfd6ca13d0c355ad2099e7f1e95155131d
                
> FileTransfer js callbacks not working in 1.6.0
> ----------------------------------------------
>
>                 Key: CB-475
>                 URL: https://issues.apache.org/jira/browse/CB-475
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>            Priority: Blocker
>             Fix For: 1.6.0
>
>
> The callbacks are still using the old cast style. Remove.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira