[GitHub] tweise commented on issue #7249: [FLINK-11048] Ability to programmatically execute streaming pipeline with savepoint restore

[GitBox <gi...@apache.org>]

tweise commented on issue #7249: [FLINK-11048] Ability to programmatically execute streaming pipeline with savepoint restore
URL: https://github.com/apache/flink/pull/7249#issuecomment-447403037
 
 
   @mxm I think the constructor proliferation suffers from its own issues: besides repetition you need to decide how to prioritize parameters that naturally have no priority. And again anything with a long parameter list is not only hard to read but also toxic for backward compatible code evolution.
   
   Ideally we would just have one parameter to execute, which could be of type `ExecutionParameters` and hold the job name as well as the savepoint info. Anything else that might be needed in the future can be added without breaking the interface contract. But that isn't easy to accomplish due to how the code has been cast. The difficulty comes from the protected executeRemotely method that we cannot change. How about passing the savepoint parameter or before mentioned new parameters holder through a thread local instead of the instance variable? The difference how we pass it internally is cosmetic and not important to the user. The question of savepoint vs. generalized execution parameters seems more interesting. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services