You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/12 17:03:43 UTC

[GitHub] [tvm] vinx13 commented on a diff in pull request #11289: [Schedule] Allowed typing.Tuple in tir.schedule._type_checker

vinx13 commented on code in PR #11289:
URL: https://github.com/apache/tvm/pull/11289#discussion_r871620960


##########
python/tvm/tir/schedule/_type_checker.py:
##########
@@ -134,14 +169,25 @@ def _type_check_atomic(v: Any, name: str, type_: Any) -> Optional[str]:
         return None if isinstance(v, type_) else _type_check_err(v, name, type_)
 
     def _type_check_list(v: List[Any], name: str, type_: Any) -> Optional[str]:
-        if not isinstance(v, (list, tuple)):
+        if not isinstance(v, list):

Review Comment:
   implicit cast from tuple to list is allowed if the element types are the same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org