You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opendal.apache.org by "trim21 (via GitHub)" <gi...@apache.org> on 2024/11/18 03:06:08 UTC
Add python39/310 support back
GitHub user trim21 created a discussion: Add python39/310 support back
we drop py<3.11 support in https://github.com/apache/opendal/discussions/4625#discussioncomment-11286854 because we don't have enough pypi space for wheel, and because of the stable API we used, we have to choose cp311.
I'm proposal we add these versions back without abi3 flags. and once we drop these version.
For python>=3.11, only abi3 wheel are provided.
GitHub link: https://github.com/apache/opendal/discussions/5335
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
GitHub user Xuanwo added a comment to the discussion: Add python39/310 support back
Please note that OpenDAL hasn't released support for version 3.10 for a long time. The actual number of 3.10 users might be even higher than shown here.
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11287120
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 added a comment to the discussion: Add python39/310 support back
another options is to relex Python requirements and remove abi3 features from pyo3 so at least cp310 uses can compile wheel by themselves without changing any code
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11287369
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 added a comment to the discussion: Add python39/310 support back
cp39 is arguable, but we should really consider add cp310 back
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11297474
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 edited a discussion: Add python39/310 support back
we drop py<3.11 support in https://github.com/apache/opendal/discussions/4625#discussioncomment-11286854 because we don't have enough pypi space for wheel, and because of the stable API we used, we have to choose cp311.
Now we have more pypi spaces, I proposal we add these versions back without abi3 flags.
For python>=3.11, only abi3 wheel are provided.
for this idea, what we need:
1. move `pyo3` abi3 feature to lib's feature.
2. change build steps to cp3.11 with abi3 feature and cp3.9/3.10 without abi3 feature.
3. change tests to add cp39/310 back and test with abi3 when py>=3.11
GitHub link: https://github.com/apache/opendal/discussions/5335
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 edited a discussion: Add python39/310 support back
we drop py<3.11 support in https://github.com/apache/opendal/discussions/4625#discussioncomment-11286854 because we don't have enough pypi space for wheel, and because of the stable API we used, we have to choose cp311.
Now we have more pypi spaces, I proposal we add these versions back without abi3 flags.
For python>=3.11, only abi3 wheel are provided.
GitHub link: https://github.com/apache/opendal/discussions/5335
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
GitHub user Xuanwo added a comment to the discussion: Add python39/310 support back
Here are some data from the `bigquery-public-data.pypi.file_downloads`:
```sql
SELECT
REGEXP_EXTRACT(details.python, r'^([0-9]+\.[0-9]+)') as python_version,
COUNT(*) as download_count
FROM `bigquery-public-data.pypi.file_downloads`
WHERE
file.project = 'opendal'
AND timestamp >= TIMESTAMP(DATE_SUB(CURRENT_DATE(), INTERVAL 6 MONTH))
AND details.python IS NOT NULL
GROUP BY python_version
ORDER BY download_count DESC;
```
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11287106
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 edited a discussion: Add python39/310 support back
we drop py<3.11 support in https://github.com/apache/opendal/discussions/4625#discussioncomment-11286854 because we don't have enough pypi space for wheel, and because of the stable API we used, we have to choose cp311.
Now we have more pypi spaces, I proposal we add these versions back without abi3 flags.
For python>=3.11, only abi3 wheel are provided.
for this proposal, what we need:
1. move `pyo3` abi3 feature to top-level feature in py binding cargo.
2. change build steps to cp3.11 with abi3 feature and cp3.9/3.10 without abi3 feature.
3. change tests to add cp39/310 back and test with abi3 when py>=3.11
GitHub link: https://github.com/apache/opendal/discussions/5335
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 closed a discussion: Add python39/310 support back
we drop py<3.11 support in https://github.com/apache/opendal/discussions/4625#discussioncomment-11286854 because we don't have enough pypi space for wheel, and because of the stable API we used, we have to choose cp311.
Now we have more pypi spaces, I proposal we add these versions back without abi3 flags.
For python>=3.11, only abi3 wheel are provided.
for this proposal, what we need:
1. move `pyo3` abi3 feature to top-level feature in py binding cargo.
2. change build steps to cp3.11 with abi3 feature and cp3.9/3.10 without abi3 feature.
3. change tests to add cp39/310 back and test with abi3 when py>=3.11 （if we have）
GitHub link: https://github.com/apache/opendal/discussions/5335
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
GitHub user Xuanwo added a comment to the discussion: Add python39/310 support back
Thank you @trim21, this proposal has been implemented in https://github.com/apache/opendal/pull/5347
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11316669
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
GitHub user PsiACE added a comment to the discussion: Add python39/310 support back
I think 3.10 is a good choice to get users started with the newer opendal. P.S. Our team is currently using 3.10 and has no plans to upgrade at this time, and we are not direct users of python binding.
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11301072
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 edited a comment on the discussion: Add python39/310 support back
another options is to relex Python requirements and remove abi3 features from pyo3 so at least cp39/cp310 uses can install from sdist
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11287369
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 edited a discussion: Add python39/310 support back
we drop py<3.11 support in https://github.com/apache/opendal/discussions/4625#discussioncomment-11286854 because we don't have enough pypi space for wheel, and because of the stable API we used, we have to choose cp311.
Now we have more pypi spaces, I proposal we add these versions back without abi3 flags.
For python>=3.11, only abi3 wheel are provided.
for this idea, what we need:
1. move `pyo3` abi3 feature to top-level feature.
2. change build steps to cp3.11 with abi3 feature and cp3.9/3.10 without abi3 feature.
3. change tests to add cp39/310 back and test with abi3 when py>=3.11
GitHub link: https://github.com/apache/opendal/discussions/5335
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 edited a comment on the discussion: Add python39/310 support back
another options is to relex Python requirements and remove abi3 features from pyo3 so at least cp39/cp310 uses （with cargo installed） can install from sdist
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11287369
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 closed the discussion with a comment: Add python39/310 support back
still have the question about cp39
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11316926
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
GitHub user Xuanwo added a comment to the discussion: Add python39/310 support back
cc @Zheaoli & @PsiACE what do you think?
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11300681
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 edited a discussion: Add python39/310 support back
we drop py<3.11 support in https://github.com/apache/opendal/discussions/4625#discussioncomment-11286854 because we don't have enough pypi space for wheel, and because of the stable API we used, we have to choose cp311.
Now we have more pypi spaces, I proposal we add these versions back without abi3 flags.
For python>=3.11, only abi3 wheel are provided.
for this proposal, what we need:
1. move `pyo3` abi3 feature to top-level feature in py binding cargo.
2. change build steps to cp3.11 with abi3 feature and cp3.9/3.10 without abi3 feature.
3. change tests to add cp39/310 back and test with abi3 when py>=3.11 （if we have）
GitHub link: https://github.com/apache/opendal/discussions/5335
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org
Re: Add python39/310 support back
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
GitHub user trim21 edited a comment on the discussion: Add python39/310 support back
another options is to relex Python requirements and remove abi3 features from pyo3 so at least cp39/cp310 uses can compile wheel by themselves without changing any code
GitHub link: https://github.com/apache/opendal/discussions/5335#discussioncomment-11287369
----
This is an automatically sent email for dev@opendal.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@opendal.apache.org