You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by kr...@apache.org on 2021/11/11 18:53:39 UTC

[hive] branch master updated: HIVE-25610: Handle partition field comments for Iceberg tables ADDENDUM (Krisztian Kasa, reviewed by Peter Vary)

This is an automated email from the ASF dual-hosted git repository.

krisztiankasa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 012b2a1  HIVE-25610: Handle partition field comments for Iceberg tables ADDENDUM (Krisztian Kasa, reviewed by Peter Vary)
012b2a1 is described below

commit 012b2a10867f07d455d9bd61f35d63385f1ecc2e
Author: Krisztian Kasa <ka...@gmail.com>
AuthorDate: Thu Nov 11 19:53:11 2021 +0100

    HIVE-25610: Handle partition field comments for Iceberg tables ADDENDUM (Krisztian Kasa, reviewed by Peter Vary)
---
 serde/if/serde.thrift                                        |  2 ++
 serde/src/gen/thrift/gen-cpp/serde_constants.cpp             |  4 ++++
 serde/src/gen/thrift/gen-cpp/serde_constants.h               |  2 ++
 .../org/apache/hadoop/hive/serde/serdeConstants.java         |  4 ++--
 .../thrift/gen-php/org/apache/hadoop/hive/serde/Constant.php | 12 ++++++++++++
 .../thrift/gen-py/org_apache_hadoop_hive_serde/constants.py  |  2 ++
 serde/src/gen/thrift/gen-rb/serde_constants.rb               |  4 ++++
 7 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/serde/if/serde.thrift b/serde/if/serde.thrift
index e3570f6..04a593c 100644
--- a/serde/if/serde.thrift
+++ b/serde/if/serde.thrift
@@ -75,6 +75,8 @@ const string LIST_COLUMNS = "columns";
 const string LIST_COLUMN_TYPES = "columns.types";
 const string LIST_PARTITION_COLUMNS = "partition.columns";
 const string LIST_PARTITION_COLUMN_TYPES = "partition.columns.types";
+const string LIST_COLUMN_COMMENTS = "columns.comments";
+const string LIST_PARTITION_COLUMN_COMMENTS = "partition.columns.comments";
 
 const string TIMESTAMP_FORMATS = "timestamp.formats";
 const string COLUMN_NAME_DELIMITER = "column.name.delimiter";
diff --git a/serde/src/gen/thrift/gen-cpp/serde_constants.cpp b/serde/src/gen/thrift/gen-cpp/serde_constants.cpp
index a63a45a..59ae265 100644
--- a/serde/src/gen/thrift/gen-cpp/serde_constants.cpp
+++ b/serde/src/gen/thrift/gen-cpp/serde_constants.cpp
@@ -103,6 +103,10 @@ serdeConstants::serdeConstants() {
 
   LIST_PARTITION_COLUMN_TYPES = "partition.columns.types";
 
+  LIST_COLUMN_COMMENTS = "columns.comments";
+
+  LIST_PARTITION_COLUMN_COMMENTS = "partition.columns.comments";
+
   TIMESTAMP_FORMATS = "timestamp.formats";
 
   COLUMN_NAME_DELIMITER = "column.name.delimiter";
diff --git a/serde/src/gen/thrift/gen-cpp/serde_constants.h b/serde/src/gen/thrift/gen-cpp/serde_constants.h
index 051ee81..87b940f 100644
--- a/serde/src/gen/thrift/gen-cpp/serde_constants.h
+++ b/serde/src/gen/thrift/gen-cpp/serde_constants.h
@@ -61,6 +61,8 @@ class serdeConstants {
   std::string LIST_COLUMN_TYPES;
   std::string LIST_PARTITION_COLUMNS;
   std::string LIST_PARTITION_COLUMN_TYPES;
+  std::string LIST_COLUMN_COMMENTS;
+  std::string LIST_PARTITION_COLUMN_COMMENTS;
   std::string TIMESTAMP_FORMATS;
   std::string COLUMN_NAME_DELIMITER;
   std::set<std::string>  PrimitiveTypes;
diff --git a/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java b/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
index 1a64aca..1a268e3 100644
--- a/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
+++ b/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
@@ -97,12 +97,12 @@ public class serdeConstants {
 
   public static final java.lang.String LIST_COLUMN_TYPES = "columns.types";
 
-  public static final java.lang.String LIST_COLUMN_COMMENTS = "columns.comments";
-
   public static final java.lang.String LIST_PARTITION_COLUMNS = "partition.columns";
 
   public static final java.lang.String LIST_PARTITION_COLUMN_TYPES = "partition.columns.types";
 
+  public static final java.lang.String LIST_COLUMN_COMMENTS = "columns.comments";
+
   public static final java.lang.String LIST_PARTITION_COLUMN_COMMENTS = "partition.columns.comments";
 
   public static final java.lang.String TIMESTAMP_FORMATS = "timestamp.formats";
diff --git a/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Constant.php b/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Constant.php
index 1820350..c57ade6 100644
--- a/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Constant.php
+++ b/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Constant.php
@@ -64,6 +64,8 @@ final class Constant extends \Thrift\Type\TConstant
     static protected $LIST_COLUMN_TYPES;
     static protected $LIST_PARTITION_COLUMNS;
     static protected $LIST_PARTITION_COLUMN_TYPES;
+    static protected $LIST_COLUMN_COMMENTS;
+    static protected $LIST_PARTITION_COLUMN_COMMENTS;
     static protected $TIMESTAMP_FORMATS;
     static protected $COLUMN_NAME_DELIMITER;
     static protected $PrimitiveTypes;
@@ -300,6 +302,16 @@ final class Constant extends \Thrift\Type\TConstant
         return "partition.columns.types";
     }
 
+    protected static function init_LIST_COLUMN_COMMENTS()
+    {
+        return "columns.comments";
+    }
+
+    protected static function init_LIST_PARTITION_COLUMN_COMMENTS()
+    {
+        return "partition.columns.comments";
+    }
+
     protected static function init_TIMESTAMP_FORMATS()
     {
         return "timestamp.formats";
diff --git a/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py b/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
index 4a123e5..ccd6eec 100644
--- a/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
+++ b/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
@@ -58,6 +58,8 @@ LIST_COLUMNS = "columns"
 LIST_COLUMN_TYPES = "columns.types"
 LIST_PARTITION_COLUMNS = "partition.columns"
 LIST_PARTITION_COLUMN_TYPES = "partition.columns.types"
+LIST_COLUMN_COMMENTS = "columns.comments"
+LIST_PARTITION_COLUMN_COMMENTS = "partition.columns.comments"
 TIMESTAMP_FORMATS = "timestamp.formats"
 COLUMN_NAME_DELIMITER = "column.name.delimiter"
 PrimitiveTypes = set((
diff --git a/serde/src/gen/thrift/gen-rb/serde_constants.rb b/serde/src/gen/thrift/gen-rb/serde_constants.rb
index 0f861d2..bb048cd 100644
--- a/serde/src/gen/thrift/gen-rb/serde_constants.rb
+++ b/serde/src/gen/thrift/gen-rb/serde_constants.rb
@@ -99,6 +99,10 @@ LIST_PARTITION_COLUMNS = %q"partition.columns"
 
 LIST_PARTITION_COLUMN_TYPES = %q"partition.columns.types"
 
+LIST_COLUMN_COMMENTS = %q"columns.comments"
+
+LIST_PARTITION_COLUMN_COMMENTS = %q"partition.columns.comments"
+
 TIMESTAMP_FORMATS = %q"timestamp.formats"
 
 COLUMN_NAME_DELIMITER = %q"column.name.delimiter"