You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Akira Ajisaka (Jira)" <ji...@apache.org> on 2021/10/18 10:23:00 UTC

[jira] [Resolved] (HADOOP-17932) distcp file length comparison have no effect

     [ https://issues.apache.org/jira/browse/HADOOP-17932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akira Ajisaka resolved HADOOP-17932.
------------------------------------
    Fix Version/s: 3.3.2
                   3.4.0
       Resolution: Fixed

Committed to trunk and branch-3.3. Thanks [~adol] for your contribution!

> distcp file length comparison have no effect
> --------------------------------------------
>
>                 Key: HADOOP-17932
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17932
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common, tools, tools/distcp
>    Affects Versions: 3.3.1
>            Reporter: yinan zhan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0, 3.3.2
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> the params for compareFileLengthsAndChecksums in RetriableFileCopyCommand have no effect
> current is
> {code:java}
>         DistCpUtils.compareFileLengthsAndChecksums(source.getLen(), sourceFS,
>                 sourcePath, sourceChecksum, targetFS,
>                 targetPath, skipCrc, source.getLen());{code}
> {code:java}
> public static void compareFileLengthsAndChecksums(long srcLen,
>            FileSystem sourceFS, Path source, FileChecksum sourceChecksum,
>            FileSystem targetFS, Path target, boolean skipCrc,
>            long targetLen) throws IOException {
>   if (srcLen != targetLen) {
>     throw new IOException(
>         DistCpConstants.LENGTH_MISMATCH_ERROR_MSG + source + " (" + srcLen
>             + ") and target:" + target + " (" + targetLen + ")");
>   }
> {code}
> so, compare source.getLen() with source.getLen()...
> It should be like below in history view
> {code:java}
>         DistCpUtils.compareFileLengthsAndChecksums(source.getLen(), sourceFS,
>                 sourcePath, sourceChecksum, targetFS,
>                 targetPath, skipCrc, bytesRead);
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org