[GitHub] [inlong] healchow commented on a diff in pull request #5837: [INLONG-5836][Manager] Fix the source status related behavior problems

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5837:
URL: https://github.com/apache/inlong/pull/5837#discussion_r965961309


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/AbstractSourceOperator.java:
##########
@@ -155,22 +153,25 @@ public void updateOpt(SourceRequest request, Integer groupStatus, String operato
         entity.setModifier(operator);
 
         // Re-issue task if necessary
-        entity.setPreviousStatus(entity.getStatus());
-        if (GroupStatus.forCode(groupStatus).equals(GroupStatus.CONFIG_SUCCESSFUL)) {
-            entity.setStatus(SourceStatus.TO_BE_ISSUED_ADD.getCode());
-        } else {
-            switch (SourceStatus.forCode(entity.getStatus())) {
-                case SOURCE_NORMAL:
-                    entity.setStatus(SourceStatus.TO_BE_ISSUED_ADD.getCode());
-                    break;
-                case SOURCE_FAILED:
-                    entity.setStatus(SourceStatus.SOURCE_NEW.getCode());
-                    break;
-                default:
-                    // others leave it be
-                    break;
+        if (!entity.getSourceType().equals(SourceType.AUTO_PUSH)) {

Review Comment:
   Suggest moving this check to the beginning of this method, if it is `AUTO_PUSH` source, just print a log and then return.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org