You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/01/27 18:42:34 UTC
Review Request 56031: Hive2 View - Switching tabs after executing
query loses state
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56031/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19753
https://issues.apache.org/jira/browse/AMBARI-19753
Repository: ambari
Description
-------
added a model parameter to save isQueryRunning state.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 23f16b0
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 2ecf967
Diff: https://reviews.apache.org/r/56031/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56031: Hive2 View - Switching tabs after executing
query loses state
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56031/#review163473
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Jan. 27, 2017, 6:42 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56031/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 6:42 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19753
> https://issues.apache.org/jira/browse/AMBARI-19753
>
>
> Repository: ambari
>
>
> Description
> -------
>
> added a model parameter to save isQueryRunning state.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 23f16b0
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 2ecf967
>
> Diff: https://reviews.apache.org/r/56031/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56031: Hive2 View - Switching tabs after executing
query loses state
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56031/#review163385
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 27, 2017, 6:42 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56031/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 6:42 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19753
> https://issues.apache.org/jira/browse/AMBARI-19753
>
>
> Repository: ambari
>
>
> Description
> -------
>
> added a model parameter to save isQueryRunning state.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 23f16b0
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 2ecf967
>
> Diff: https://reviews.apache.org/r/56031/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56031: Hive2 View - Switching tabs after executing
query loses state
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56031/
-----------------------------------------------------------
(Updated Jan. 30, 2017, 9:48 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19753
https://issues.apache.org/jira/browse/AMBARI-19753
Repository: ambari
Description
-------
added a model parameter to save isQueryRunning state.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 9021e90
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 7d387f0
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 7f91d6c
Diff: https://reviews.apache.org/r/56031/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha