You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2018/01/15 23:50:03 UTC
[GitHub] flink pull request #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Pr...
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5301
[FLINK-8267] [Kinesis Connector] update Kinesis Producer example for setting Region key
## What is the purpose of the change
Update doc to guide users to use KPL's native keys to set regions.
This originates from a bug that we forgot to set region keys explicitly for kinesis connector, which has been fixed. According to the previous discussion between @tzulitai and I, we want to remove AWSConfigConstants in 2.0 because it basically copies/translates config keys of KPL/KCL, which doesn't add much value.
Guide users to use KPL's native keys to set regions can be the first step that facilitates the migration.
## Brief change log
- updated doc
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
## Documentation
- Does this pull request introduce a new feature? (no)
cc @tzulitai
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-8267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5301
----
commit b4034f67e727fef68740221e3b31cd131c905df1
Author: Bowen Li <bo...@...>
Date: 2018-01-02T19:21:28Z
update local branch
commit 11e9c255cd51304c5281d55226fbb6fe8360d8a2
Author: Bowen Li <bo...@...>
Date: 2018-01-04T01:35:11Z
remove sh
commit e322a5416b0f4f89c366b98bb3571fbf6b7d460a
Author: Bowen Li <bo...@...>
Date: 2017-12-17T06:18:55Z
update doc
commit 1b447633df4a8bfe7c4c19e7ae91aab6157756d7
Author: Bowen Li <bo...@...>
Date: 2018-01-15T23:48:38Z
format code snippet
commit 4ede4b5a89d4bfcda8dcc845ab1da42177d22358
Author: Bowen Li <bo...@...>
Date: 2018-01-15T23:49:37Z
remove ';' from scala code
----
---
[GitHub] flink issue #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Producer ...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5301
Make sense. Updated the PR also squashed all commits (first time using squash!)
---
[GitHub] flink issue #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Producer ...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5301
@bowenli86 can you squash the commits into a single one, with appropriate commit message? Thanks!
---
[GitHub] flink issue #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Producer ...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5301
cc @tzulitai
---
[GitHub] flink pull request #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Pr...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5301#discussion_r162904042
--- Diff: docs/dev/connectors/kinesis.md ---
@@ -271,9 +271,9 @@ For the monitoring to work, the user accessing the stream needs access to the Cl
{% highlight java %}
Properties producerConfig = new Properties();
// Required configs
-producerConfig.put(AWSConfigConstants.AWS_REGION, "us-east-1");
producerConfig.put(AWSConfigConstants.AWS_ACCESS_KEY_ID, "aws_access_key_id");
producerConfig.put(AWSConfigConstants.AWS_SECRET_ACCESS_KEY, "aws_secret_access_key");
+producerConfig.put("Region", "us-east-1");
--- End diff --
Is the "Region" string defined in some KPL class, e.g. `XXConstants`?
If yes, maybe we should just demonstrate that class.
That would make it more clear that the KPL configuration keys are directly supported.
---
[GitHub] flink pull request #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Pr...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5301#discussion_r163075196
--- Diff: docs/dev/connectors/kinesis.md ---
@@ -271,9 +271,9 @@ For the monitoring to work, the user accessing the stream needs access to the Cl
{% highlight java %}
Properties producerConfig = new Properties();
// Required configs
-producerConfig.put(AWSConfigConstants.AWS_REGION, "us-east-1");
producerConfig.put(AWSConfigConstants.AWS_ACCESS_KEY_ID, "aws_access_key_id");
producerConfig.put(AWSConfigConstants.AWS_SECRET_ACCESS_KEY, "aws_secret_access_key");
+producerConfig.put("Region", "us-east-1");
--- End diff --
no, KPL doesn't have such configs. KPL takes a string like 'Region' and tries to find its setter using reflection.
---