[GitHub] [tvm] electriclilies commented on a change in pull request #7438: [ONNX] Enable GPU in ONNX importer tests

[GitBox <gi...@apache.org>]

electriclilies commented on a change in pull request #7438:
URL: https://github.com/apache/tvm/pull/7438#discussion_r597071262



##########
File path: tests/scripts/task_python_frontend.sh
##########
@@ -31,6 +31,9 @@ find . -type f -path "*.pyc" | xargs rm -f
 # Rebuild cython
 make cython3
 
+# Only run GPU enabled tests on GPU
+export PYTEST_ADDOPTS="-m gpu $PYTEST_ADDOPTS"

Review comment:
       Right now, all the tests are running on GPU, which causes the argmin / argmax onnx test to fail. The ONNX test file uses @tvm.testing.uses_gpu to indicate whether we should run tests on GPU or not, but right now it doesn't do anything, which is definitely not good. I think we should try to move towards enabling the @tvm.testing.uses_gpu in the long run.
   
   What if I set PYTEST_ADDOPTS before the onnx tests, and reset it after? Since the file uses the @tvm.testing.uses_gpu a lot, I think we should either remove the decorators or let them actually do something.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org