You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/28 13:39:32 UTC

[GitHub] [spark] srowen commented on a change in pull request #29888: [SPARK-33012] Upgrade fabric8 to 4.10.3

srowen commented on a change in pull request #29888:
URL: https://github.com/apache/spark/pull/29888#discussion_r495945567



##########
File path: resource-managers/kubernetes/core/pom.xml
##########
@@ -89,6 +88,12 @@
     </dependency>
     <!-- End of shaded deps. -->
 
+    <dependency>

Review comment:
       Why does this become necessary, out of curiosity? looks like a downgrade. I'm just wondering if it affects anything else that depends on okhttp.

##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -166,14 +167,31 @@ kerby-pkix/1.0.1//kerby-pkix-1.0.1.jar
 kerby-util/1.0.1//kerby-util-1.0.1.jar
 kerby-xdr/1.0.1//kerby-xdr-1.0.1.jar
 kryo-shaded/4.0.2//kryo-shaded-4.0.2.jar
-kubernetes-client/4.9.2//kubernetes-client-4.9.2.jar
-kubernetes-model-common/4.9.2//kubernetes-model-common-4.9.2.jar
-kubernetes-model/4.9.2//kubernetes-model-4.9.2.jar
+kubernetes-client/4.10.3//kubernetes-client-4.10.3.jar
+kubernetes-model-admissionregistration/4.10.3//kubernetes-model-admissionregistration-4.10.3.jar
+kubernetes-model-apiextensions/4.10.3//kubernetes-model-apiextensions-4.10.3.jar
+kubernetes-model-apps/4.10.3//kubernetes-model-apps-4.10.3.jar
+kubernetes-model-autoscaling/4.10.3//kubernetes-model-autoscaling-4.10.3.jar

Review comment:
       Are all of these additional deps needed - if they really aren't we might exclude them for tidiness.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org