You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Andy Grove (Jira)" <ji...@apache.org> on 2020/09/05 17:04:00 UTC
[jira] [Resolved] (ARROW-9916) [RUST] Avoid cloning ArrayData in
several places
[ https://issues.apache.org/jira/browse/ARROW-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Grove resolved ARROW-9916.
-------------------------------
Fix Version/s: 2.0.0
Resolution: Fixed
Issue resolved by pull request 8113
[https://github.com/apache/arrow/pull/8113]
> [RUST] Avoid cloning ArrayData in several places
> ------------------------------------------------
>
> Key: ARROW-9916
> URL: https://issues.apache.org/jira/browse/ARROW-9916
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust
> Affects Versions: 1.0.0
> Reporter: Jörn Horstmann
> Assignee: Jörn Horstmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I noticed this while benchmarking improvements in ARROW-9895. A flamegraph showed a significant amount of time spent in Arc::clone/atomic_add followed by Arc::drop/atomic_sub
> The Array trait has two methods for accessing ArrayData, `.data()` which clones an `Arc<ArrayData>` and `.data_ref()` which only borrows the data. In many places borrow can be used instead of clone.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)