You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/08/13 03:27:12 UTC
[GitHub] codecov-io commented on issue #2228: [Dubbo- support tag router
feature] Add a new Router implement -- TagRouter
codecov-io commented on issue #2228: [Dubbo- support tag router feature] Add a new Router implement -- TagRouter
URL: https://github.com/apache/incubator-dubbo/pull/2228#issuecomment-412399666
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2228?src=pr&el=h1) Report
> Merging [#2228](https://codecov.io/gh/apache/incubator-dubbo/pull/2228?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e35084015b6af5b39fe8dca279202e81d59ce082?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `61.36%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2228 +/- ##
============================================
- Coverage 54.68% 54.65% -0.04%
- Complexity 5159 5172 +13
============================================
Files 569 571 +2
Lines 25038 25084 +46
Branches 4457 4464 +7
============================================
+ Hits 13692 13709 +17
- Misses 9309 9334 +25
- Partials 2037 2041 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/config/AbstractReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFJlZmVyZW5jZUNvbmZpZy5qYXZh) | `93.75% <ø> (ø)` | `27 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdEludGVyZmFjZUNvbmZpZy5qYXZh) | `80.78% <ø> (ø)` | `81 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeURpcmVjdG9yeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXJGYWN0b3J5LmphdmE=) | `100% <100%> (ø)` | `2 <2> (?)` | |
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.58% <33.33%> (-2.88%)` | `42 <1> (+1)` | |
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `66.66% <66.66%> (ø)` | `11 <11> (?)` | |
| [...o/common/serialize/kryo/utils/ReflectionUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUva3J5by91dGlscy9SZWZsZWN0aW9uVXRpbHMuamF2YQ==) | `66.66% <0%> (-13.34%)` | `3% <0%> (+2%)` | |
| [...n/serialize/support/SerializableClassRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9zdXBwb3J0L1NlcmlhbGl6YWJsZUNsYXNzUmVnaXN0cnkuamF2YQ==) | `66.66% <0%> (-13.34%)` | `4% <0%> (+1%)` | |
| [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh) | `72.88% <0%> (-8.48%)` | `12% <0%> (-1%)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2228/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2228?src=pr&el=footer). Last update [e350840...b70c32c](https://codecov.io/gh/apache/incubator-dubbo/pull/2228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org