You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Alex-Sessler <gi...@git.apache.org> on 2016/04/29 12:28:10 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
GitHub user Alex-Sessler opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164
Added FLAG_SECURE support
I'm using this Plugin together with the Privacyscreen Plugin (https://github.com/devgeeks/PrivacyScreenPlugin), which sets the FLAG_SECURE on the main window, which disallows screenshots and makes sure a blank page is shown in the recent apps. When the IAB is open, the IAB Dialog needs to have those flags as well (when set on the main window).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Alex-Sessler/cordova-plugin-inappbrowser flag_secure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #164
----
commit 15e2a22e3c99ad065653252f8c1207edaefe26e6
Author: Alexander Sessler <al...@jls.ch>
Date: 2016-04-29T10:25:46Z
make sure FLAG_SECURE is respected when set on main window
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #164: Added FLAG_SECURE support on Android
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164
@Alex-Sessler If you're still interested in contributing this at some point, can you keep this up to date? It seems that enough changes have happened to master that there's conflicts.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Posted by Alex-Sessler <gi...@git.apache.org>.
Github user Alex-Sessler commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215814096
I think i could have time to add this some time this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Posted by Alex-Sessler <gi...@git.apache.org>.
Github user Alex-Sessler commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-216067099
Okay, so I added a "securewindow" flag, that allows you to set the FLAG_SECURE on the IAB Dialog. Since I use a highly modified custom IAB version from an older release, I haven't tested this exact version, just copied over the changes. Since my App also uses the googlemaps plugin, which messes with view layers, i couldn't really test if everything works as expected.
Could anyone of you please test if the following things apply:
- If FLAG_SECURE is set on the main window and not specifically set on the IAB, is the IAB window secured as well (no screenshots + empty view in previous apps)?
- If FLAG_SECURE is NOT set on the main window and IS specifically set on the IAB, is the IAB window secured?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215792971
Does it make sense to have this be an iab option? Could a non-secure activity want to display a secure iab?
Maybe that is step 2. This looks good though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Posted by devgeeks <gi...@git.apache.org>.
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215812203
+1 for option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Posted by devgeeks <gi...@git.apache.org>.
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215697044
Well, it certainly works as advertised with the PrivacyScreenPlugin, anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Posted by Alex-Sessler <gi...@git.apache.org>.
Github user Alex-Sessler commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-216067702
I wanted to change my solution to also cover the edge case where a user could have the app secured but doesn't want the IAB to be secured. I ended up reverting the commit because I think it adds more unneccesary complexity that it actually helps. To make screenshots possible (although the main windows' FLAG_SECURE is set) you'd probably have to end up changing the flags of the main window and set them back when the IAB is closed. i'll just leave this open until someone actually needs this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Posted by devgeeks <gi...@git.apache.org>.
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215685335
Nice, I'll try to have a look at this as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-219915534
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/164/commits/e5cdffdbd3cadf5bc5bf11f6566bf7483ca270e2)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3/)
| Builder Name | Console Output | Test Report | Device Logs |
| :---: | :---: | :---: | :---: |
| [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-8.1-store/artifact/) |
| [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-10-store/artifact/) |
| [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=windows-slave,platformName=windows-8.1-phone/artifact/) |
| [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=mac-slave,platformName=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=mac-slave,platformName=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=mac-slave,platformName=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=mac-slave,platformName=ios/artifact/) |
| [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=mac-slave,platformName=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=mac-slave,platformName=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=mac-slave,platformName=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/3//label=mac-slave,platformName=android/artifact/) |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org